You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Paul Lindner <li...@inuus.com> on 2011/08/02 13:05:39 UTC
Re: Review Request: Enable closure compiler by default
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1264
-----------------------------------------------------------
been trying to apply this patch but I'm seeing endtoend tests fail.. just me?
- Paul
On 2011-07-26 14:11:17, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1179/
> -----------------------------------------------------------
>
> (Updated 2011-07-26 14:11:17)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Enable closure with simple optimizations turned on.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1150288
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsCompileMode.java 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/CompilationProcessor.java 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js 1150920
>
> Diff: https://reviews.apache.org/r/1179/diff
>
>
> Testing
> -------
>
> Existing js tests pass
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Enable closure compiler by default
Posted by Dan Dumont <dd...@us.ibm.com>.
> On 2011-08-02 11:05:39, Paul Lindner wrote:
> > been trying to apply this patch but I'm seeing endtoend tests fail.. just me?
Just got back from vacation, I'm still building fine after updating. I did need to build clean first though.
Can you try again?
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1264
-----------------------------------------------------------
On 2011-07-26 14:11:17, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1179/
> -----------------------------------------------------------
>
> (Updated 2011-07-26 14:11:17)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Enable closure with simple optimizations turned on.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1150288
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsCompileMode.java 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/CompilationProcessor.java 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java 1150920
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js 1150920
>
> Diff: https://reviews.apache.org/r/1179/diff
>
>
> Testing
> -------
>
> Existing js tests pass
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Enable closure compiler by default
Posted by Stanton Sievers <ss...@us.ibm.com>.
I'm seeing this as well. I'll look into this today.
From: "Paul Lindner" <li...@inuus.com>
To: "shindig" <de...@shindig.apache.org>, Dan Dumont/Westford/IBM@Lotus,
"Paul Lindner" <li...@inuus.com>,
Date: 08/02/2011 07:05
Subject: Re: Review Request: Enable closure compiler by default
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1179/#review1264
-----------------------------------------------------------
been trying to apply this patch but I'm seeing endtoend tests fail.. just
me?
- Paul
On 2011-07-26 14:11:17, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1179/
> -----------------------------------------------------------
>
> (Updated 2011-07-26 14:11:17)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Enable closure with simple optimizations turned on.
>
>
> Diffs
> -----
>
>
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/js/CompilationProcessorTest.java
1150920
>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js
1150288
>
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties
1150920
>
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/JsCompileMode.java
1150920
>
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/CompilationProcessor.java
1150920
>
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/js/JsCompilerModule.java
1150920
>
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
1150920
>
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/globals/globals.js
1150920
>
> Diff: https://reviews.apache.org/r/1179/diff
>
>
> Testing
> -------
>
> Existing js tests pass
>
>
> Thanks,
>
> Dan
>
>