You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/05/04 16:36:25 UTC

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2672: Add new blip count to GC

ctubbsii commented on code in PR #2672:
URL: https://github.com/apache/accumulo/pull/2672#discussion_r865043174


##########
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java:
##########
@@ -206,6 +212,7 @@ private void confirmDeletes(GarbageCollectionEnvironment gce,
 
     confirmDeletesFromReplication(gce.getReplicationNeededIterator(),
         candidateMap.entrySet().iterator());
+    return blipCount;
   }
 
   protected void confirmDeletesFromReplication(

Review Comment:
   Are blip flags deprecated? I didn't think they were... but I also can't remember what they are for, without a deep dive into the code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org