You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Thomas Neidhart <th...@gmail.com> on 2014/06/29 15:05:52 UTC
[CANCEL][VOTE] Release Email 1.3.3 based on RC1
On 06/28/2014 03:20 PM, Gary Gregory wrote:
> Builds "mvn clean site" ok with:
>
> Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e;
> 2014-06-17T09:51:42-04:00)
> Maven home: C:\Java\apache-maven-3.2.2
> Java version: 1.7.0_60, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_60\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>
> but not with:
>
> Apache Maven 3.2.2 (45f7c06d68e745d05611f7fd14efb6594181933e;
> 2014-06-17T09:51:42-04:00)
> Maven home: C:\Java\apache-maven-3.2.2
> Java version: 1.8.0_05, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.8.0_05\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"
>
> where I get:
>
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 53.766s
> [INFO] Finished at: Sat Jun 28 08:55:12 EDT 2014
> [INFO] Final Memory: 48M/203M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.3:site (default-site) on
> project commons-email: Error during page generation: Error rendering Maven
> report:
> [ERROR] Exit code: 1 - javadoc: warning - Error fetching URL:
> http://docs.oracle.com/javase/6/docs/api
> [ERROR] javadoc: warning - Error fetching URL:
> http://docs.oracle.com/javaee/6/api
> [ERROR]
> C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\AbstractEmailTest.java:524:
> warning: no @throws for java.lang.Exception
> [ERROR] protected URL createInvalidURL() throws Exception {
> [ERROR] ^
> [ERROR]
> C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:553:
> warning: no @throws for java.lang.Exception
> [ERROR] public void testAddZipUrl() throws Exception
> [ERROR] ^
> [ERROR]
> C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:606:
> warning: no @throws for java.lang.Exception
> [ERROR] public void testCallingBuildMimeMessageBeforeSent() throws
> Exception {
> [ERROR] ^
> [ERROR]
> C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:645:
> error: element not closed: pre
> [ERROR] * creates a plain content and HTML content using <pre> tags.
> [ERROR] ^
> [ERROR]
> C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:648:
> warning: no @throws for org.apache.commons.mail.EmailException
> [ERROR] public void testSendWithPlainTextButNoHtmlContent() throws
> EmailException, IOException
> [ERROR] ^
> [ERROR]
> C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:648:
> warning: no @throws for java.io.IOException
> [ERROR] public void testSendWithPlainTextButNoHtmlContent() throws
> EmailException, IOException
> [ERROR] ^
> [ERROR]
> C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\HtmlEmailTest.java:690:
> warning: no @throws for java.lang.Exception
> [ERROR] public void testEmbedFileWithCID() throws Exception
> [ERROR] ^
> [ERROR]
> C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\InvalidInternetAddressTest.java:80:
> error: exception not thrown: java.lang.Exception
> [ERROR] * @throws Exception on any error
> [ERROR] ^
> [ERROR]
> C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\MultiPartEmailTest.java:386:
> error: unknown tag: todo
> [ERROR] /** @todo implement test for GetContainer */
> [ERROR] ^
> [ERROR]
> C:\temp\rc\commons-email-1.3.3-src\src\test\java\org\apache\commons\mail\SimpleEmailTest.java:78:
> error: unknown tag: todo
> [ERROR] * @todo Add code to test the popBeforeSmtp() settings
> [ERROR] ^
> [ERROR]
> [ERROR] Command line was: "C:\Program
> Files\Java\jdk1.8.0_05\jre\..\bin\javadoc.exe" @options @packages
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> 'C:\temp\rc\commons-email-1.3.3-src\target\site\testapidocs' dir.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions,
> please read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
>
> So the claim to fix Java 8 Javadocs by
> https://issues.apache.org/jira/browse/EMAIL-136 is not 100% complete.
>
> I fixed the Javadoc 8 errors in SVN.
>
> -0 because we claim to have fixed building Java 8 but we have not 100%. So
> I think that if we recut an RC with my trunk changes OR drop EMAIL-136 as
> claimed to be fixed, I would +1.
>
> FindBugs (the RC uses 2.5.2) blows up on Java 8:
>
> [INFO] Fork Value is true
> [java] The following errors occurred during analysis:
> [java] Jun 28, 2014 9:07:19 AM edu.umd.cs.findbugs.TextUIBugReporter
> reportAnalysisError
> [java] SEVERE: Unable to get XClass for java/lang/StringBuilder
> [java] java.lang.ArrayIndexOutOfBoundsException: 26721
> [java] at org.objectweb.asm.ClassReader.readClass(Unknown Source)
> [java] at org.objectweb.asm.ClassReader.accept(Unknown Source)
> [java] at
> edu.umd.cs.findbugs.asm.FBClassReader.accept(FBClassReader.java:44)
> [java] at org.objectweb.asm.ClassReader.accept(Unknown Source)
> [java] at
> edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:110)
> [java] at
> edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:554)
> [java] at
> edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:76)
> [java] at
> edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:38)
> [java] at
> edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getClassAnalysis(AnalysisCache.java:266)
> [java] at
> edu.umd.cs.findbugs.ba.XFactory.getXClass(XFactory.java:652)
> [java] at
> edu.umd.cs.findbugs.ba.ch.Subtypes2.addInheritanceEdge(Subtypes2.java:1227)
> [java] at
> edu.umd.cs.findbugs.ba.ch.Subtypes2.addSupertypeEdges(Subtypes2.java:1200)
> [java] at
> edu.umd.cs.findbugs.ba.ch.Subtypes2.addClassAndGetClassVertex(Subtypes2.java:275)
> [java] at
> edu.umd.cs.findbugs.ba.ch.Subtypes2.addClass(Subtypes2.java:244)
> [java] at
> edu.umd.cs.findbugs.ba.AnalysisCacheToAnalysisContextAdapter.setAppClassList(AnalysisCacheToAnalysisContextAdapter.java:400)
> [java] at
> edu.umd.cs.findbugs.FindBugs2.setAppClassList(FindBugs2.java:982)
> [java] at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:225)
> [java] at edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:391)
> [java] at edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1300)
> ... more...
>
> But there does not seem to be a away to get FB to work on Java 8 with this
> Maven build?... Arg! I tried to update to the latest FB 2.5.4 and it did
> not help:
>
> [INFO] Fork Value is true
> [java] The following errors occurred during analysis:
> [java] Unable to get XClass for java/lang/StringBuilder
> [java] java.lang.ArrayIndexOutOfBoundsException: 26721
> [java] At org.objectweb.asm.ClassReader.readClass(Unknown Source)
> [java] At org.objectweb.asm.ClassReader.accept(Unknown Source)
> [java] At
> edu.umd.cs.findbugs.asm.FBClassReader.accept(FBClassReader.java:44)
> [java] At org.objectweb.asm.ClassReader.accept(Unknown Source)
> [java] At
> edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:110)
> [java] At
> edu.umd.cs.findbugs.classfile.engine.ClassParserUsingASM.parse(ClassParserUsingASM.java:587)
> [java] At
> edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:76)
> [java] At
> edu.umd.cs.findbugs.classfile.engine.ClassInfoAnalysisEngine.analyze(ClassInfoAnalysisEngine.java:38)
> [java] At
> edu.umd.cs.findbugs.classfile.impl.AnalysisCache.getClassAnalysis(AnalysisCache.java:268)
> [java] At
> edu.umd.cs.findbugs.ba.XFactory.getXClass(XFactory.java:652)
> [java] At
> edu.umd.cs.findbugs.ba.ch.Subtypes2.addInheritanceEdge(Subtypes2.java:1260)
> [java] At
> edu.umd.cs.findbugs.ba.ch.Subtypes2.addSupertypeEdges(Subtypes2.java:1233)
> [java] At
> edu.umd.cs.findbugs.ba.ch.Subtypes2.addClassAndGetClassVertex(Subtypes2.java:275)
> [java] At
> edu.umd.cs.findbugs.ba.ch.Subtypes2.addClass(Subtypes2.java:244)
> [java] At
> edu.umd.cs.findbugs.ba.AnalysisContext.setAppClassList(AnalysisContext.java:941)
> [java] At
> edu.umd.cs.findbugs.FindBugs2.setAppClassList(FindBugs2.java:997)
> [java] At
> edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:225)
> [java] At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:393)
> [java] At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1317)
> ... more ...
>
> Thoughts?
>
> Aside from that it looks good.
>
> Gary
>
>
>
>
>
> On Fri, Jun 27, 2014 at 4:35 PM, Thomas Neidhart <th...@gmail.com>
> wrote:
>
>> This is a vote to release Commons Email 1.3.3 based on the first RC.
>>
>> Email 1.3.3 RC1 is available for review here:
>> https://dist.apache.org/repos/dist/dev/commons/email/
>> (svn revision 5697)
>>
>> Maven artifacts are here:
>>
>>
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-1036/org/apache/commons/commons-email/1.3.3/
>>
>> Details of changes since 1.3.2 are in the release notes:
>>
>> https://dist.apache.org/repos/dist/dev/commons/email/RELEASE-NOTES.txt
>>
>> http://people.apache.org/builds/commons/email/1.3.3/RC1/changes-report.html
>>
>> The tag is here:
>>
>>
>> https://svn.apache.org/repos/asf/commons/proper/email/tags/EMAIL_1_3_3_RC1/
>> (svn 1606212)
>>
>> Site:
>> http://people.apache.org/builds/commons/email/1.3.3/RC1/
>> (note some *relative* links are broken and some new directories are
>> not yet created - these will be OK once the site is deployed)
>>
>> KEYS:
>> http://www.apache.org/dist/commons/KEYS
>>
>> Please review the release candidate and vote.
>> This vote will close no sooner that 72 hours from now.
>>
>> [ ] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
The vote is cancelled to create a new RC which includes the javadoc
fixes that are already in trunk.
Thomas
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org