You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by fe...@apache.org on 2022/11/05 08:11:30 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #3577][FOLLOWUP] Set default connectionUrl to empty string to prevent the UT stuck for metadata request retry
This is an automated email from the ASF dual-hosted git repository.
feiwang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new e0cb4c665 [KYUUBI #3577][FOLLOWUP] Set default connectionUrl to empty string to prevent the UT stuck for metadata request retry
e0cb4c665 is described below
commit e0cb4c665a318d706fb0f79795a209ba359b8caf
Author: Fei Wang <fw...@ebay.com>
AuthorDate: Sat Nov 5 16:11:21 2022 +0800
[KYUUBI #3577][FOLLOWUP] Set default connectionUrl to empty string to prevent the UT stuck for metadata request retry
### _Why are the changes needed?_
For UT, we might open batch session directly and do not via rest frontend service.
So the connection url is null, and will stuck for metadata request retrying.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #3765 from turboFei/ci_fix.
Closes #3577
523eef4c0 [Fei Wang] fix ci
Authored-by: Fei Wang <fw...@ebay.com>
Signed-off-by: Fei Wang <fw...@ebay.com>
---
.../src/main/scala/org/apache/kyuubi/session/KyuubiSession.scala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSession.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSession.scala
index 06c938775..988b3ee41 100644
--- a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSession.scala
+++ b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSession.scala
@@ -33,7 +33,7 @@ abstract class KyuubiSession(
val sessionType: SessionType
- val connectionUrl = conf.get(KYUUBI_SESSION_CONNECTION_URL_KEY).orNull
+ val connectionUrl = conf.get(KYUUBI_SESSION_CONNECTION_URL_KEY).getOrElse("")
def getSessionEvent: Option[KyuubiSessionEvent]