You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2022/03/16 00:58:00 UTC

[jira] [Commented] (HBASE-26833) Avoid waiting to clear buffer usage of ReplicationSourceShipper when aborting the RS

    [ https://issues.apache.org/jira/browse/HBASE-26833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17507288#comment-17507288 ] 

Hudson commented on HBASE-26833:
--------------------------------

Results for branch branch-2.4
	[build #307 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/307/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/307/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/307/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/307/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/307/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Avoid waiting to clear buffer usage of ReplicationSourceShipper when aborting the RS
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-26833
>                 URL: https://issues.apache.org/jira/browse/HBASE-26833
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver, Replication
>    Affects Versions: 2.4.10
>            Reporter: Xiaolin Ha
>            Assignee: Xiaolin Ha
>            Priority: Major
>             Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.11
>
>
> HBASE-24813 introduced the clear of buffer used in replication source shipper, but there is sleep in the method, if the variable sleepForRetries has a large value, and there are many wal groups, the aborting of RS may last a long time, but we should only do some necessary things in the aborting progress.
> {code:java}
> void clearWALEntryBatch() {
>   long timeout = System.currentTimeMillis() + this.shipEditsTimeout;
>   while(this.isAlive() || this.entryReader.isAlive()){
>     try {
>       if (System.currentTimeMillis() >= timeout) {
>         LOG.warn("Shipper clearWALEntryBatch method timed out whilst waiting reader/shipper "
>           + "thread to stop. Not cleaning buffer usage. Shipper alive: {}; Reader alive: {}",
>           this.source.getPeerId(), this.isAlive(), this.entryReader.isAlive());
>         return;
>       } else {
>         // Wait both shipper and reader threads to stop
>         Thread.sleep(this.sleepForRetries);
>       }
>     } catch (InterruptedException e) {
>       LOG.warn("{} Interrupted while waiting {} to stop on clearWALEntryBatch. "
>           + "Not cleaning buffer usage: {}", this.source.getPeerId(), this.getName(), e);
>       return;
>     }
>   }
> ...... {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)