[GitHub] [incubator-superset] Zanoellia opened a new pull request #8427: Welcome page title: use app_name instead of 'Superset'

[GitBox <gi...@apache.org>]

Zanoellia opened a new pull request #8427: Welcome page title: use app_name instead of 'Superset'
URL: https://github.com/apache/incubator-superset/pull/8427
 
 
   ### CATEGORY
   
   - [x] Enhancement (new features, refinement)
   
   ### SUMMARY
   
   The title of the welcome page is a hard coded string (value: "Superset"). When setting the `APP_NAME` to a custom name, we expect to see this name for the page title.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   When changing the `APP_NAME` in `superset/config.py` file:
   ```diff
    # GLOBALS FOR APP Builder
    # ------------------------------
    # Uncomment to setup Your App name
   -APP_NAME = "Superset"
   +APP_NAME = "My Custom Name"
   ```
   
   **Before**: the title of the welcome page is not updated (neither for pages without an explicit title)
   
   ![before](https://user-images.githubusercontent.com/5038274/67294039-92420880-f4e5-11e9-8c90-ab02a15a4270.png)
   
   **After**: the title is updated
   
   ![after](https://user-images.githubusercontent.com/5038274/67294056-99691680-f4e5-11e9-920a-6be7d8688d8d.png)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org