You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "dbron0000 (via GitHub)" <gi...@apache.org> on 2023/07/24 15:22:37 UTC
[I] [Feature Request]: Add "linting" feature for code quality evaluation (hop)
dbron0000 opened a new issue, #3103:
URL: https://github.com/apache/hop/issues/3103
### What would you like to happen?
Our team would like to evaluate new pipelines and workflows that are committed to our code repository via Git. Some examples are:
1. How many steps are on the canvas? Too many might be an indication that the process should be refined to be more modular.
2. Are the steps on the canvas named appropriately? If the names of the steps are the default names - that might be an indication that the developer should provide clearer naming to describe the specific action of the step.
3. Are notes on the canvas? The samples are good examples of the helpful descriptions provided by canvas notes. If notes are missing, this might indicate that high level descriptions that are easy to see are missing.
4. Are credentials hard coded (vs. using variables)?
Many other examples here - most linting tools allow custom evaluations - so ideally this would be a Hop based tool that would allow pipelines/workflows to be created to evaluate the newly submitted code.
### Issue Priority
Priority: 3
### Issue Component
Component: Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature Request]: Add "linting" feature for code quality evaluation (hop)
Posted by "dbron0000 (via GitHub)" <gi...@apache.org>.
dbron0000 commented on issue #3103:
URL: https://github.com/apache/hop/issues/3103#issuecomment-1652196242
@gertwieland -- yea, me too. These examples hit close to home unfortunately.
I'll edit the requirements list to add that the linting rules should be easily shared. Perhaps a public Git repo or perhaps making them easily shared via a marketplace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature Request]: Add "linting" feature for code quality evaluation (hop)
Posted by "gertwieland (via GitHub)" <gi...@apache.org>.
gertwieland commented on issue #3103:
URL: https://github.com/apache/hop/issues/3103#issuecomment-1652720982
Maybe this is helpful: I use "Tabular Editor" to create and maintain Analysis Services Data models (in DAX).
They offer a "Best Practice Analyzer", and I find it extremely helpful (again, for obvious reasons ;) ).
[Here's a link.](https://docs.tabulareditor.com/te2/Best-Practice-Analyzer.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Feature Request]: Add "linting" feature for code quality evaluation (hop)
Posted by "gertwieland (via GitHub)" <gi...@apache.org>.
gertwieland commented on issue #3103:
URL: https://github.com/apache/hop/issues/3103#issuecomment-1651890132
I like this idea, very much so. It would provide another level of "quality control".
In a sense, it's in line with Hop's philosophy: Metadata about pipelines and workflows.
(And yes, according to the criteria listed above, some of my own pipelines would certainly get flagged ;) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org