[GitHub] [ozone] jojochuang commented on a change in pull request #2404: HDDS-5427. Either re-interrupt this method or rethrow the "InterruptedException" that can be caught here

[GitBox <gi...@apache.org>]

jojochuang commented on a change in pull request #2404:
URL: https://github.com/apache/ozone/pull/2404#discussion_r667675310



##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -218,9 +218,11 @@ public synchronized void close() {
       channel.shutdownNow();
       try {
         channel.awaitTermination(60, TimeUnit.MINUTES);
-      } catch (Exception e) {
+      } catch (InterruptedException e) {
         LOG.error("Unexpected exception while waiting for channel termination",

Review comment:
       can you update this log text as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org