You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by dianfu <gi...@git.apache.org> on 2017/06/16 03:44:36 UTC
[GitHub] flink pull request #4132: [FLINK-6933] [cep] Refactor NFACompiler to reduce ...
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/4132
[FLINK-6933] [cep] Refactor NFACompiler to reduce code duplication
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dianfu/flink FLINK-6933
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4132.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4132
----
commit 97da09af4828661fcde22c9d09aee69cfa7d7ac5
Author: Dian Fu <fu...@alibaba-inc.com>
Date: 2017-06-16T03:43:04Z
[FLINK-6933] [cep] Refactor NFACompiler to reduce code duplication
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4132: [FLINK-6933] [cep] Refactor NFACompiler to reduce ...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/4132#discussion_r122564524
--- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java ---
@@ -348,7 +348,7 @@ long getWindowTime() {
return copyOfSink;
}
- private void addStopStates(final State<T> state) {
+ private void addStopState(final State<T> state) {
--- End diff --
I feel it should stay as `addStopStates` as it can add more than one state.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4132: [FLINK-6933] [cep] Refactor NFACompiler to reduce code du...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4132
After an offline discussion with @dianfu , we decided to close this PR and merge this change with https://github.com/apache/flink/pull/4121/ as it is more relevant there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4132: [FLINK-6933] [cep] Refactor NFACompiler to reduce code du...
Posted by dianfu <gi...@git.apache.org>.
Github user dianfu commented on the issue:
https://github.com/apache/flink/pull/4132
@kl0u @dawidwys Thanks for the comments. As discussed offline, I will close this PR and merge the changes to #4121.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4132: [FLINK-6933] [cep] Refactor NFACompiler to reduce ...
Posted by dianfu <gi...@git.apache.org>.
Github user dianfu closed the pull request at:
https://github.com/apache/flink/pull/4132
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4132: [FLINK-6933] [cep] Refactor NFACompiler to reduce code du...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4132
R: @kl0u or @dawidwys for review, please 😃
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---