You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/09/20 18:49:09 UTC

[GitHub] [helix] NealSun96 commented on pull request #1842: Fix TestClusterAggregateMetrics

NealSun96 commented on pull request #1842:
URL: https://github.com/apache/helix/pull/1842#issuecomment-923187331


   @jiajunwang On line 178 we have `Assert.assertTrue(verifier.verifyByPolling());` That checks for cluster convergence like you said. 
   
   The previous test causes the verifier to mistakenly verify an intermediate state instead of the final state; adding the maintenance mode should mitigate that, and let the verifier do its job. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org