You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ja...@apache.org on 2016/12/29 08:04:41 UTC
[1/2] incubator-carbondata git commit: fix load performace
Repository: incubator-carbondata
Updated Branches:
refs/heads/master aaf98edca -> 93f23ccb8
fix load performace
Project: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/commit/31582395
Tree: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/tree/31582395
Diff: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/diff/31582395
Branch: refs/heads/master
Commit: 315823956a1418eff2977919413b344c6f5e42c7
Parents: aaf98ed
Author: foryou2030 <fo...@126.com>
Authored: Fri Dec 23 16:46:21 2016 +0800
Committer: jackylk <ja...@huawei.com>
Committed: Thu Dec 29 15:46:27 2016 +0800
----------------------------------------------------------------------
.../newflow/converter/impl/MeasureFieldConverterImpl.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/31582395/processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/MeasureFieldConverterImpl.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/MeasureFieldConverterImpl.java b/processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/MeasureFieldConverterImpl.java
index c419d46..fa2d037 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/MeasureFieldConverterImpl.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/MeasureFieldConverterImpl.java
@@ -22,6 +22,7 @@ import org.apache.carbondata.common.logging.LogService;
import org.apache.carbondata.common.logging.LogServiceFactory;
import org.apache.carbondata.core.carbon.metadata.datatype.DataType;
import org.apache.carbondata.core.carbon.metadata.schema.table.column.CarbonMeasure;
+import org.apache.carbondata.core.constants.CarbonCommonConstants;
import org.apache.carbondata.core.util.DataTypeUtil;
import org.apache.carbondata.processing.newflow.DataField;
import org.apache.carbondata.processing.newflow.converter.BadRecordLogHolder;
@@ -57,7 +58,8 @@ public class MeasureFieldConverterImpl implements FieldConverter {
throws CarbonDataLoadingException {
String value = row.getString(index);
Object output;
- if (value == null) {
+ boolean isNull = CarbonCommonConstants.MEMBER_DEFAULT_VAL.equals(value);
+ if (value == null || value.length() == 0 || isNull) {
logHolder.setReason(
"The value " + " \"" + value + "\"" + " with column name " + measure.getColName()
+ " and column data type " + dataType + " is not a valid " + dataType + " type.");
[2/2] incubator-carbondata git commit: [CARBONDATA-558] Fix load
performace issue when use_kettle=false This closes #459
Posted by ja...@apache.org.
[CARBONDATA-558] Fix load performace issue when use_kettle=false This closes #459
Project: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/commit/93f23ccb
Tree: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/tree/93f23ccb
Diff: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/diff/93f23ccb
Branch: refs/heads/master
Commit: 93f23ccb8689aa48a6cfcba12ef39ec863a09590
Parents: aaf98ed 3158239
Author: jackylk <ja...@huawei.com>
Authored: Thu Dec 29 16:04:27 2016 +0800
Committer: jackylk <ja...@huawei.com>
Committed: Thu Dec 29 16:04:27 2016 +0800
----------------------------------------------------------------------
.../newflow/converter/impl/MeasureFieldConverterImpl.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------