You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/17 01:41:41 UTC
[GitHub] [arrow-rs] askoa opened a new pull request, #3126: Remove serde attribute to fix postcard roundtrip.
askoa opened a new pull request, #3126:
URL: https://github.com/apache/arrow-rs/pull/3126
# Which issue does this PR close?
Closes #3082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3126: Don't Skip Serializing Empty Metadata (#3082)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3126:
URL: https://github.com/apache/arrow-rs/pull/3126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3126: Don't Skip Serializing Empty Metadata (#3082)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3126:
URL: https://github.com/apache/arrow-rs/pull/3126#issuecomment-1322761347
Benchmark runs are scheduled for baseline = 870f0fa7d8975247df7bc734ce08e5f807027f53 and contender = 528a0728359946436454678625630ad55e6499fb. 528a0728359946436454678625630ad55e6499fb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/93445b33f9e1447f911b43c19a4dc3c2...058602031e084b099248822ba3133a22/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/4dcf07eeaec94b0c82ea834f39d2805b...a13bc91cd7144850ad6fc70a7da455db/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/287ad43085bf466284b4dc593a46a645...c3726e9ac85343afa3f964cbcceb1267/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9f7a5a43febc48a8815c6cdd5ae050e2...f33dae88ba454fecadf1f3bf28a53ff5/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3126: Don't Skip Serializing Empty Metadata (#3082)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3126:
URL: https://github.com/apache/arrow-rs/pull/3126#discussion_r1028101695
##########
arrow-schema/Cargo.toml:
##########
@@ -45,3 +45,4 @@ default = []
[dev-dependencies]
serde_json = "1.0"
+postcard = { version = "1.0.2", default-features = false, features = ["alloc"] }
Review Comment:
I personally would prefer we test using bincode as opposed to postcard, just because the former appears to be more widely adopted. It is a dev dependency so not massively concerned either way, just trying to keep the footprint limited to more mature libraries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org