You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2017/08/28 12:31:57 UTC

[GitHub] flink pull request #4609: Assigner

GitHub user pnowojski opened a pull request:

    https://github.com/apache/flink/pull/4609

    Assigner

    This PR is a pure refactor and shouldn't change any functionality. It should be covered by existing tests like `CheckpointCoordinatorTest`
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pnowojski/flink assigner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4609.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4609
    
----
commit 06c1367c0a9a05c13bc5abf4bae96241350a276e
Author: Piotr Nowojski <pi...@gmail.com>
Date:   2017-08-25T11:59:36Z

    [hotfix][runtime] Checkstyle changes in TaskStateSnapshot

commit efc46f7cc1508499e421946767b326ba91118c38
Author: Piotr Nowojski <pi...@gmail.com>
Date:   2017-08-25T13:23:15Z

    [FLINK-7541][runtime] Refactor StateAssignmentOperation and use OperatorID
    
    This is not complete refactor, some methods still relay on the order of the
    new and old operators.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4609: [FLINK-7541] Refactor StateAssignmentOperation

Posted by pnowojski <gi...@git.apache.org>.

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4609
  
    Sorry @tillrohrmann I have missed that :(
    
    @StefanRRichter I pushed a fixed version (but lets wait for travis to pass)


---

[GitHub] flink issue #4609: [FLINK-7541] Refactor StateAssignmentOperation

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4609
  
    Please don't close this PR, because the commit was reverted. Using `Multimap#get` in the `StateAssignmentOperation` makes the `OperatorSubtaskState` not serializable. The `WindowCheckpointingITCase` caught the problem.


---

[GitHub] flink issue #4609: [FLINK-7541] Refactor StateAssignmentOperation

Posted by StefanRRichter <gi...@git.apache.org>.

Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/4609
  
    Alright, second attempt to merge this.


---

[GitHub] flink issue #4609: [FLINK-7541] Refactor StateAssignmentOperation

Posted by StefanRRichter <gi...@git.apache.org>.

Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/4609
  
    Merged in f1b2b83d63. Please close the PR and the JIRA.


---

[GitHub] flink issue #4609: Assigner

Posted by pnowojski <gi...@git.apache.org>.

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4609
  
    @StefanRRichter please take a look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4609: [FLINK-7541] Refactor StateAssignmentOperation

Posted by StefanRRichter <gi...@git.apache.org>.

Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/4609
  
    Yes, I also missed it between some unrelated Kafka test failures :-( Will do a second attempt if all is green this time.


---

[GitHub] flink pull request #4609: [FLINK-7541] Refactor StateAssignmentOperation

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4609


---

[GitHub] flink issue #4609: [FLINK-7541] Refactor StateAssignmentOperation

Posted by pnowojski <gi...@git.apache.org>.

Github user pnowojski commented on the issue:

    https://github.com/apache/flink/pull/4609
  
    Surprisingly even kafka tests have passed this time oO


---