You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Norman Maurer (JIRA)" <se...@james.apache.org> on 2011/04/10 20:20:05 UTC

[jira] [Created] (IMAP-292) SEARCH is not handled correctly

SEARCH <sequence-set> is not handled correctly
----------------------------------------------

                 Key: IMAP-292
                 URL: https://issues.apache.org/jira/browse/IMAP-292
             Project: JAMES Imap
          Issue Type: Bug
          Components: Protocol
    Affects Versions: 0.2-M1
            Reporter: Norman Maurer
            Assignee: Norman Maurer
             Fix For: 0.2


 SEARCH <sequence-set>... is not handled correctly in many cases

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Commented] (IMAP-292) SEARCH is not handled correctly

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/IMAP-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087175#comment-13087175 ] 

Norman Maurer commented on IMAP-292:
------------------------------------

I think we don't need th getFirstUidAfter think. We should just use the given range without trying todo any optimization. We just should not fail...

> SEARCH <sequence-set> is not handled correctly
> ----------------------------------------------
>
>                 Key: IMAP-292
>                 URL: https://issues.apache.org/jira/browse/IMAP-292
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Protocol
>    Affects Versions: 0.2-M1
>            Reporter: Norman Maurer
>             Fix For: 0.2
>
>
>  SEARCH <sequence-set>... is not handled correctly in many cases

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Closed] (IMAP-292) SEARCH is not handled correctly

Posted by "Wojtek Strzalka (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/IMAP-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wojtek Strzalka closed IMAP-292.
--------------------------------

    Resolution: Fixed

it works OK 


> SEARCH <sequence-set> is not handled correctly
> ----------------------------------------------
>
>                 Key: IMAP-292
>                 URL: https://issues.apache.org/jira/browse/IMAP-292
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Protocol
>    Affects Versions: 0.2-M1
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 0.2
>
>
>  SEARCH <sequence-set>... is not handled correctly in many cases

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Reopened] (IMAP-292) SEARCH is not handled correctly

Posted by "Wojtek Strzalka (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/IMAP-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wojtek Strzalka reopened IMAP-292:
----------------------------------

      Assignee:     (was: Norman Maurer)

There are still cases where it doesn't work. Below sample iPhone <-> IMAP session:

-------------------------------------------------------------------
	* OK JAMES IMAP4rev1 Server  Server D620 is ready.
1 LOGIN <LOGIN> <PWD>
	1 OK LOGIN completed.
2 CAPABILITY
	* CAPABILITY IMAP4rev1 LITERAL+ CHILDREN I18NLEVEL=1 WITHIN ESEARCH SEARCHRES XLIST IDLE NAMESPACE UIDPLUS UNSELECT AUTH=PLAIN SASL-IR ENABLE
	2 OK CAPABILITY completed.
3 SELECT "Deleted Items"
	* FLAGS (\Answered \Deleted \Draft \Flagged \Seen)
	* 0 EXISTS
	* 0 RECENT
	* OK [UIDVALIDITY 127] UIDs valid
	* OK [PERMANENTFLAGS (\Answered \Deleted \Draft \Flagged \Seen)] Limited
	* OK [UIDNEXT 2696] Predicted next UID
	3 OK [READ-WRITE] SELECT completed.
4 UID SEARCH RETURN (COUNT) 1:* DELETED
	4 BAD SEARCH failed. Invalid messageset.
5 NOOP
	5 OK NOOP completed.
6 UID SEARCH RETURN (ALL) 1:* NOT DELETED
	6 BAD SEARCH failed. Invalid messageset.
7 UID SEARCH RETURN (COUNT) 1:* DELETED
	7 BAD SEARCH failed. Invalid messageset.
8 LIST "" ""
	* LIST (\Noselect) "/" ""
	8 OK LIST completed.
9 STATUS "Deleted Items" (UNSEEN)
	* STATUS "Deleted Items" (UNSEEN 0)
	9 OK STATUS completed.
10 NOOP
	10 OK NOOP completed.
11 UID SEARCH RETURN (ALL) 2147483598:* NOT DELETED
	11 BAD SEARCH failed. Invalid messageset.
12 STATUS "Deleted Items" (UNSEEN)
	* STATUS "Deleted Items" (UNSEEN 0)
	12 OK STATUS completed.
13 NOOP
	13 OK NOOP completed.
14 UID SEARCH RETURN (ALL) 2147483598:* NOT DELETED
	14 BAD SEARCH failed. Invalid messageset.
15 STATUS "Deleted Items" (UNSEEN)
	* STATUS "Deleted Items" (UNSEEN 0)
	15 OK STATUS completed.
--------------------------------------------------------------------------------

where we can see a lot of BAD answers.

The idea is to use the approach like it was implemented before (see the commit log for the issue) but instead of using:

------------
final int lowMsn = (int) lowVal;
lowUid = selected.uid(lowMsn);
if (lowUid == SelectedMailbox.NO_SUCH_MESSAGE) lowUid = selected.getFirstUid();
-------------
do smth like: 
------------
final int lowMsn = (int) lowVal;
lowUid = selected.uid(lowMsn);
if (lowUid == SelectedMailbox.NO_SUCH_MESSAGE) lowUid = selected.getFirstUidAfter(lowMsn);
-------------

That would need to support both uid & msn requests this way.

WDYT? 


> SEARCH <sequence-set> is not handled correctly
> ----------------------------------------------
>
>                 Key: IMAP-292
>                 URL: https://issues.apache.org/jira/browse/IMAP-292
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Protocol
>    Affects Versions: 0.2-M1
>            Reporter: Norman Maurer
>             Fix For: 0.2
>
>
>  SEARCH <sequence-set>... is not handled correctly in many cases

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Commented] (IMAP-292) SEARCH is not handled correctly

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/IMAP-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090910#comment-13090910 ] 

Norman Maurer commented on IMAP-292:
------------------------------------

Maybe I missed something but for me it looks like the expected output. Could you tell my why you think its incorrect ?

> SEARCH <sequence-set> is not handled correctly
> ----------------------------------------------
>
>                 Key: IMAP-292
>                 URL: https://issues.apache.org/jira/browse/IMAP-292
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Protocol
>    Affects Versions: 0.2-M1
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 0.2
>
>
>  SEARCH <sequence-set>... is not handled correctly in many cases

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Issue Comment Edited] (IMAP-292) SEARCH is not handled correctly

Posted by "Wojtek Strzalka (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/IMAP-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087160#comment-13087160 ] 

Wojtek Strzalka edited comment on IMAP-292 at 8/18/11 6:09 PM:
---------------------------------------------------------------

There are still cases where it doesn't work. Below sample iPhone <-> James session:

-------------------------------------------------------------------
	* OK JAMES IMAP4rev1 Server  Server D620 is ready.
1 LOGIN <LOGIN> <PWD>
	1 OK LOGIN completed.
2 CAPABILITY
	* CAPABILITY IMAP4rev1 LITERAL+ CHILDREN I18NLEVEL=1 WITHIN ESEARCH SEARCHRES XLIST IDLE NAMESPACE UIDPLUS UNSELECT AUTH=PLAIN SASL-IR ENABLE
	2 OK CAPABILITY completed.
3 SELECT "Deleted Items"
	* FLAGS (\Answered \Deleted \Draft \Flagged \Seen)
	* 0 EXISTS
	* 0 RECENT
	* OK [UIDVALIDITY 127] UIDs valid
	* OK [PERMANENTFLAGS (\Answered \Deleted \Draft \Flagged \Seen)] Limited
	* OK [UIDNEXT 2696] Predicted next UID
	3 OK [READ-WRITE] SELECT completed.
4 UID SEARCH RETURN (COUNT) 1:* DELETED
	4 BAD SEARCH failed. Invalid messageset.
5 NOOP
	5 OK NOOP completed.
6 UID SEARCH RETURN (ALL) 1:* NOT DELETED
	6 BAD SEARCH failed. Invalid messageset.
7 UID SEARCH RETURN (COUNT) 1:* DELETED
	7 BAD SEARCH failed. Invalid messageset.
8 LIST "" ""
	* LIST (\Noselect) "/" ""
	8 OK LIST completed.
9 STATUS "Deleted Items" (UNSEEN)
	* STATUS "Deleted Items" (UNSEEN 0)
	9 OK STATUS completed.
10 NOOP
	10 OK NOOP completed.
11 UID SEARCH RETURN (ALL) 2147483598:* NOT DELETED
	11 BAD SEARCH failed. Invalid messageset.
12 STATUS "Deleted Items" (UNSEEN)
	* STATUS "Deleted Items" (UNSEEN 0)
	12 OK STATUS completed.
13 NOOP
	13 OK NOOP completed.
14 UID SEARCH RETURN (ALL) 2147483598:* NOT DELETED
	14 BAD SEARCH failed. Invalid messageset.
15 STATUS "Deleted Items" (UNSEEN)
	* STATUS "Deleted Items" (UNSEEN 0)
	15 OK STATUS completed.
--------------------------------------------------------------------------------

where we can see a lot of BAD answers.

The idea is to use the approach like it was implemented before (see the commit log for the issue) but instead of using:

------------
final int lowMsn = (int) lowVal;
lowUid = selected.uid(lowMsn);
if (lowUid == SelectedMailbox.NO_SUCH_MESSAGE) lowUid = selected.getFirstUid();
-------------
do smth like: 
------------
final int lowMsn = (int) lowVal;
lowUid = selected.uid(lowMsn);
if (lowUid == SelectedMailbox.NO_SUCH_MESSAGE) lowUid = selected.getFirstUidAfter(lowMsn);
-------------

That would need to support both uid & msn requests this way.

WDYT? 


      was (Author: wstrzalka):
    There are still cases where it doesn't work. Below sample iPhone <-> IMAP session:

-------------------------------------------------------------------
	* OK JAMES IMAP4rev1 Server  Server D620 is ready.
1 LOGIN <LOGIN> <PWD>
	1 OK LOGIN completed.
2 CAPABILITY
	* CAPABILITY IMAP4rev1 LITERAL+ CHILDREN I18NLEVEL=1 WITHIN ESEARCH SEARCHRES XLIST IDLE NAMESPACE UIDPLUS UNSELECT AUTH=PLAIN SASL-IR ENABLE
	2 OK CAPABILITY completed.
3 SELECT "Deleted Items"
	* FLAGS (\Answered \Deleted \Draft \Flagged \Seen)
	* 0 EXISTS
	* 0 RECENT
	* OK [UIDVALIDITY 127] UIDs valid
	* OK [PERMANENTFLAGS (\Answered \Deleted \Draft \Flagged \Seen)] Limited
	* OK [UIDNEXT 2696] Predicted next UID
	3 OK [READ-WRITE] SELECT completed.
4 UID SEARCH RETURN (COUNT) 1:* DELETED
	4 BAD SEARCH failed. Invalid messageset.
5 NOOP
	5 OK NOOP completed.
6 UID SEARCH RETURN (ALL) 1:* NOT DELETED
	6 BAD SEARCH failed. Invalid messageset.
7 UID SEARCH RETURN (COUNT) 1:* DELETED
	7 BAD SEARCH failed. Invalid messageset.
8 LIST "" ""
	* LIST (\Noselect) "/" ""
	8 OK LIST completed.
9 STATUS "Deleted Items" (UNSEEN)
	* STATUS "Deleted Items" (UNSEEN 0)
	9 OK STATUS completed.
10 NOOP
	10 OK NOOP completed.
11 UID SEARCH RETURN (ALL) 2147483598:* NOT DELETED
	11 BAD SEARCH failed. Invalid messageset.
12 STATUS "Deleted Items" (UNSEEN)
	* STATUS "Deleted Items" (UNSEEN 0)
	12 OK STATUS completed.
13 NOOP
	13 OK NOOP completed.
14 UID SEARCH RETURN (ALL) 2147483598:* NOT DELETED
	14 BAD SEARCH failed. Invalid messageset.
15 STATUS "Deleted Items" (UNSEEN)
	* STATUS "Deleted Items" (UNSEEN 0)
	15 OK STATUS completed.
--------------------------------------------------------------------------------

where we can see a lot of BAD answers.

The idea is to use the approach like it was implemented before (see the commit log for the issue) but instead of using:

------------
final int lowMsn = (int) lowVal;
lowUid = selected.uid(lowMsn);
if (lowUid == SelectedMailbox.NO_SUCH_MESSAGE) lowUid = selected.getFirstUid();
-------------
do smth like: 
------------
final int lowMsn = (int) lowVal;
lowUid = selected.uid(lowMsn);
if (lowUid == SelectedMailbox.NO_SUCH_MESSAGE) lowUid = selected.getFirstUidAfter(lowMsn);
-------------

That would need to support both uid & msn requests this way.

WDYT? 

  
> SEARCH <sequence-set> is not handled correctly
> ----------------------------------------------
>
>                 Key: IMAP-292
>                 URL: https://issues.apache.org/jira/browse/IMAP-292
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Protocol
>    Affects Versions: 0.2-M1
>            Reporter: Norman Maurer
>             Fix For: 0.2
>
>
>  SEARCH <sequence-set>... is not handled correctly in many cases

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Resolved] (IMAP-292) SEARCH is not handled correctly

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/IMAP-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Norman Maurer resolved IMAP-292.
--------------------------------

    Resolution: Fixed
      Assignee: Norman Maurer

I think its now how it should be ... could you re-test

> SEARCH <sequence-set> is not handled correctly
> ----------------------------------------------
>
>                 Key: IMAP-292
>                 URL: https://issues.apache.org/jira/browse/IMAP-292
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Protocol
>    Affects Versions: 0.2-M1
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 0.2
>
>
>  SEARCH <sequence-set>... is not handled correctly in many cases

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Issue Comment Edited] (IMAP-292) SEARCH is not handled correctly

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
    [ https://issues.apache.org/jira/browse/IMAP-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087175#comment-13087175 ] 

Norman Maurer edited comment on IMAP-292 at 8/18/11 6:31 PM:
-------------------------------------------------------------

I think we don't need th getFirstUidAfter thing. We should just use the given range without trying todo any optimization. We just should not fail...

      was (Author: norman):
    I think we don't need th getFirstUidAfter think. We should just use the given range without trying todo any optimization. We just should not fail...
  
> SEARCH <sequence-set> is not handled correctly
> ----------------------------------------------
>
>                 Key: IMAP-292
>                 URL: https://issues.apache.org/jira/browse/IMAP-292
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Protocol
>    Affects Versions: 0.2-M1
>            Reporter: Norman Maurer
>             Fix For: 0.2
>
>
>  SEARCH <sequence-set>... is not handled correctly in many cases

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Reopened] (IMAP-292) SEARCH is not handled correctly

Posted by "Wojtek Strzalka (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/IMAP-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wojtek Strzalka reopened IMAP-292:
----------------------------------


It's still not OK:

g FETCH 1:* (UID)
* 1 FETCH (UID 2706)
* 2 FETCH (UID 2707)
* 3 FETCH (UID 2708)
* 4 FETCH (UID 2709)
* 5 FETCH (UID 2710)
* 6 FETCH (UID 2711)
* 7 FETCH (UID 2715)
* 8 FETCH (UID 2716)
* 9 FETCH (UID 2717)
* 10 FETCH (UID 2718)
g OK FETCH completed.
h UID SEARCH 1:2713
* SEARCH 2706 2707 2708 2709 2710 2711 2715 2716 2717 2718
h OK SEARCH completed.

> SEARCH <sequence-set> is not handled correctly
> ----------------------------------------------
>
>                 Key: IMAP-292
>                 URL: https://issues.apache.org/jira/browse/IMAP-292
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Protocol
>    Affects Versions: 0.2-M1
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 0.2
>
>
>  SEARCH <sequence-set>... is not handled correctly in many cases

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Resolved] (IMAP-292) SEARCH is not handled correctly

Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
     [ https://issues.apache.org/jira/browse/IMAP-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Norman Maurer resolved IMAP-292.
--------------------------------

    Resolution: Fixed

fixed!

> SEARCH <sequence-set> is not handled correctly
> ----------------------------------------------
>
>                 Key: IMAP-292
>                 URL: https://issues.apache.org/jira/browse/IMAP-292
>             Project: JAMES Imap
>          Issue Type: Bug
>          Components: Protocol
>    Affects Versions: 0.2-M1
>            Reporter: Norman Maurer
>            Assignee: Norman Maurer
>             Fix For: 0.2
>
>
>  SEARCH <sequence-set>... is not handled correctly in many cases

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org