[GitHub] [spark] AngersZhuuuu edited a comment on pull request #30451: [SPARK-28704][SQL][TEST] Add back Skiped HiveExternalCatalogVersionsSuite in HiveSparkSubmitSuite at JDK9+

[GitBox <gi...@apache.org>]

AngersZhuuuu edited a comment on pull request #30451:
URL: https://github.com/apache/spark/pull/30451#issuecomment-731569837


   I found that after this change , it download zookeeper test-jar
   ```
   downloading https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.6/zookeeper-3.4.6-tests.jar ...
   2020-11-20 21:45:20.389 - stderr> 	[SUCCESSFUL ] org.apache.zookeeper#zookeeper;3.4.6!zookeeper.jar(test-jar) (11ms)
   ```
   
   But.  right case is 
   ```
   downloading https://repo1.maven.org/maven2/org/apache/zookeeper/zookeeper/3.4.3/zookeeper-3.4.3.jar ...
   2020-11-19 20:25:25.892 - stderr> 	[SUCCESSFUL ] org.apache.zookeeper#zookeeper;3.4.3!zookeeper.jar (20ms)
   ```
   
   See the logical of dowloadVersion
   ```
     def resolveDependencyPaths(
         artifacts: Array[AnyRef],
         cacheDirectory: File): String = {
       artifacts.map { ai =>
         val artifactInfo = ai.asInstanceOf[Artifact]
         val artifact = artifactInfo.getModuleRevisionId
         val testSuffix = if (artifactInfo.getType == "test-jar") "-tests" else ""
         cacheDirectory.getAbsolutePath + File.separator +
           s"${artifact.getOrganisation}_${artifact.getName}-${artifact.getRevision}${testSuffix}.jar"
       }.mkString(",")
     }
   ```
   
   Seems some place artifact info is wrong?  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org