You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/10 06:12:56 UTC

[GitHub] sijie commented on a change in pull request #2762: Fix IdentitySerde

sijie commented on a change in pull request #2762: Fix IdentitySerde
URL: https://github.com/apache/pulsar/pull/2762#discussion_r223947108
 
 

 ##########
 File path: pulsar-client-cpp/python/pulsar/functions/serde.py
 ##########
 @@ -68,9 +68,9 @@ def deserialize(self, input_bytes):
       return pickle.loads(input_bytes)
 
 class IdentitySerDe(SerDe):
-  """Pickle based serializer"""
+  """utf-8 based identity serializer"""
 
 Review comment:
   I don't fully understand here. "identity" typically means not changing things, but the code here is converting between bytes and string, which doesn't seem to be correct to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services