You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/10/08 13:22:47 UTC

[GitHub] [druid] liran-funaro commented on pull request #10335: Configurable Index Type

liran-funaro commented on pull request #10335:
URL: https://github.com/apache/druid/pull/10335#issuecomment-705564572


   Thanks, @a2l007 
   I addressed all your comments in the codes, or with follow-up questions.
   Regarding the integration tests, I added tests to all the `TuningConfig` tests that validate the `AppendableIndexSpec` within `TuningConfig`.
   I think it is sufficient. Do you agree?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org