You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2011/08/03 02:30:27 UTC

[jira] [Created] (ZOOKEEPER-1142) incorrect stat output

incorrect stat output
---------------------

                 Key: ZOOKEEPER-1142
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1142
             Project: ZooKeeper
          Issue Type: Bug
          Components: server
    Affects Versions: 3.4.0
            Reporter: Patrick Hunt
            Assignee: Patrick Hunt
            Priority: Blocker
             Fix For: 3.4.0


stat output seems to be missing some end of line:

{noformat}
echo stat |nc c0309 2181
Zookeeper version: 3.4.0--1, built on 08/02/2011 22:25 GMT
Clients:
 /172.29.81.91:33378[0](queued=0,recved=1,sent=0
Latency min/avg/max: 0/28/252
Received: 246844
Sent: 266737
Outstanding: 0
Zxid: 0x4000508c2
Mode: follower
Node count: 4
{noformat}

Multiple clients end up on the same line (missing newline)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1142) incorrect stat output

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082879#comment-13082879 ] 

Hadoop QA commented on ZOOKEEPER-1142:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12489226/ZOOKEEPER-1142.patch
  against trunk revision 1152141.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/436//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/436//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/436//console

This message is automatically generated.

> incorrect stat output
> ---------------------
>
>                 Key: ZOOKEEPER-1142
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1142
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Blocker
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1142.patch
>
>
> stat output seems to be missing some end of line:
> {noformat}
> echo stat |nc c0309 2181
> Zookeeper version: 3.4.0--1, built on 08/02/2011 22:25 GMT
> Clients:
>  /172.29.81.91:33378[0](queued=0,recved=1,sent=0
> Latency min/avg/max: 0/28/252
> Received: 246844
> Sent: 266737
> Outstanding: 0
> Zxid: 0x4000508c2
> Mode: follower
> Node count: 4
> {noformat}
> Multiple clients end up on the same line (missing newline)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1142) incorrect stat output

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083059#comment-13083059 ] 

Hudson commented on ZOOKEEPER-1142:
-----------------------------------

Integrated in ZooKeeper-trunk #1260 (See [https://builds.apache.org/job/ZooKeeper-trunk/1260/])
    ZOOKEEPER-1142. incorrect stat output (phunt via mahadev)

mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1156497
Files : 
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ServerCnxn.java
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FourLetterWordsTest.java
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/NettyServerCnxn.java


> incorrect stat output
> ---------------------
>
>                 Key: ZOOKEEPER-1142
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1142
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Blocker
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1142.patch
>
>
> stat output seems to be missing some end of line:
> {noformat}
> echo stat |nc c0309 2181
> Zookeeper version: 3.4.0--1, built on 08/02/2011 22:25 GMT
> Clients:
>  /172.29.81.91:33378[0](queued=0,recved=1,sent=0
> Latency min/avg/max: 0/28/252
> Received: 246844
> Sent: 266737
> Outstanding: 0
> Zxid: 0x4000508c2
> Mode: follower
> Node count: 4
> {noformat}
> Multiple clients end up on the same line (missing newline)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1142) incorrect stat output

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-1142:
------------------------------------

    Attachment: ZOOKEEPER-1142.patch

this fixes the issue with stat (also issue with cons).

I ran through most of the commands with both nio and netty and it seems to be working ok with this patch.

I also added some specific tests to ensure this doesn't happen in future.

> incorrect stat output
> ---------------------
>
>                 Key: ZOOKEEPER-1142
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1142
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Blocker
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1142.patch
>
>
> stat output seems to be missing some end of line:
> {noformat}
> echo stat |nc c0309 2181
> Zookeeper version: 3.4.0--1, built on 08/02/2011 22:25 GMT
> Clients:
>  /172.29.81.91:33378[0](queued=0,recved=1,sent=0
> Latency min/avg/max: 0/28/252
> Received: 246844
> Sent: 266737
> Outstanding: 0
> Zxid: 0x4000508c2
> Mode: follower
> Node count: 4
> {noformat}
> Multiple clients end up on the same line (missing newline)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1142) incorrect stat output

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082942#comment-13082942 ] 

Mahadev konar commented on ZOOKEEPER-1142:
------------------------------------------

+1 the patch looks good.

> incorrect stat output
> ---------------------
>
>                 Key: ZOOKEEPER-1142
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1142
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Blocker
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1142.patch
>
>
> stat output seems to be missing some end of line:
> {noformat}
> echo stat |nc c0309 2181
> Zookeeper version: 3.4.0--1, built on 08/02/2011 22:25 GMT
> Clients:
>  /172.29.81.91:33378[0](queued=0,recved=1,sent=0
> Latency min/avg/max: 0/28/252
> Received: 246844
> Sent: 266737
> Outstanding: 0
> Zxid: 0x4000508c2
> Mode: follower
> Node count: 4
> {noformat}
> Multiple clients end up on the same line (missing newline)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira