You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Aleksey Shipilev (JIRA)" <ji...@apache.org> on 2008/08/22 08:48:45 UTC
[jira] Created: (HARMONY-5956) [classlib][pack200] Fix warnings
[classlib][pack200] Fix warnings
--------------------------------
Key: HARMONY-5956
URL: https://issues.apache.org/jira/browse/HARMONY-5956
Project: Harmony
Issue Type: Improvement
Reporter: Aleksey Shipilev
Priority: Trivial
Attachments: pack200-warnings-v1.patch
This patch fixes the warnings in pack200
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5956) [classlib][pack200] Fix warnings
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-5956:
--------------------------------------
Attachment: pack200-warnings-v1.patch
pack200-warnings-v1.patch
Patch.
> [classlib][pack200] Fix warnings
> --------------------------------
>
> Key: HARMONY-5956
> URL: https://issues.apache.org/jira/browse/HARMONY-5956
> Project: Harmony
> Issue Type: Improvement
> Reporter: Aleksey Shipilev
> Priority: Trivial
> Attachments: pack200-warnings-v1.patch
>
>
> This patch fixes the warnings in pack200
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5956) [classlib][pack200] Fix warnings
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January reassigned HARMONY-5956:
-------------------------------------
Assignee: Sian January
> [classlib][pack200] Fix warnings
> --------------------------------
>
> Key: HARMONY-5956
> URL: https://issues.apache.org/jira/browse/HARMONY-5956
> Project: Harmony
> Issue Type: Improvement
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Priority: Trivial
> Attachments: pack200-warnings-v1.patch
>
>
> This patch fixes the warnings in pack200
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5956) [classlib][pack200] Fix warnings
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January resolved HARMONY-5956.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M8
Thanks - that's much better.
v2 patch applied at r689784. Please check that it was applied as you expected.
> [classlib][pack200] Fix warnings
> --------------------------------
>
> Key: HARMONY-5956
> URL: https://issues.apache.org/jira/browse/HARMONY-5956
> Project: Harmony
> Issue Type: Improvement
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Priority: Trivial
> Fix For: 5.0M8
>
> Attachments: pack200-warnings-v1.patch, pack200-warnings-v2.patch
>
>
> This patch fixes the warnings in pack200
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5956) [classlib][pack200] Fix warnings
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev closed HARMONY-5956.
-------------------------------------
Applied OK, thanks.
> [classlib][pack200] Fix warnings
> --------------------------------
>
> Key: HARMONY-5956
> URL: https://issues.apache.org/jira/browse/HARMONY-5956
> Project: Harmony
> Issue Type: Improvement
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Priority: Trivial
> Fix For: 5.0M8
>
> Attachments: pack200-warnings-v1.patch, pack200-warnings-v2.patch
>
>
> This patch fixes the warnings in pack200
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5956) [classlib][pack200] Fix warnings
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626509#action_12626509 ]
Aleksey Shipilev commented on HARMONY-5956:
-------------------------------------------
Sure, I can.
I would delete the code rather than commenting out in o.a.h.unpack200.* - it that ok?
> [classlib][pack200] Fix warnings
> --------------------------------
>
> Key: HARMONY-5956
> URL: https://issues.apache.org/jira/browse/HARMONY-5956
> Project: Harmony
> Issue Type: Improvement
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Priority: Trivial
> Attachments: pack200-warnings-v1.patch
>
>
> This patch fixes the warnings in pack200
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5956) [classlib][pack200] Fix warnings
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626506#action_12626506 ]
Sian January commented on HARMONY-5956:
---------------------------------------
Hi Aleksey,
I don't agree with the changes to the classes in the .pack200 package in this patch because that's ongoing development and the local variables that you've deleted are there because they will be needed as development continues.
For the other classes it would be better if you deleted the code rather than commented it out because it's not very neat to have lots of commented-out code around. Would you be able to make these changes and re-create the patch?
Thanks.
> [classlib][pack200] Fix warnings
> --------------------------------
>
> Key: HARMONY-5956
> URL: https://issues.apache.org/jira/browse/HARMONY-5956
> Project: Harmony
> Issue Type: Improvement
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Priority: Trivial
> Attachments: pack200-warnings-v1.patch
>
>
> This patch fixes the warnings in pack200
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5956) [classlib][pack200] Fix warnings
Posted by "Aleksey Shipilev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Shipilev updated HARMONY-5956:
--------------------------------------
Attachment: pack200-warnings-v2.patch
pack200-warnings-v2.patch
V2 patch.
> [classlib][pack200] Fix warnings
> --------------------------------
>
> Key: HARMONY-5956
> URL: https://issues.apache.org/jira/browse/HARMONY-5956
> Project: Harmony
> Issue Type: Improvement
> Reporter: Aleksey Shipilev
> Assignee: Sian January
> Priority: Trivial
> Attachments: pack200-warnings-v1.patch, pack200-warnings-v2.patch
>
>
> This patch fixes the warnings in pack200
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.