[jira] [Commented] (KAFKA-9679) Mock consumer should behave consistent with actual consumer

["Sheikh Araf (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212016#comment-17212016 ] 

Sheikh Araf commented on KAFKA-9679:
------------------------------------

Hi [~bchen225242], I've taken a stab at this issue and raised a PR. My understanding is that during poll the MockConsumer should filter records from partitions it is currently not subscribed to. Correct me if I'm missing something.

I've also run all the unit + integration tests on my commit and they seem to pass locally (except `SocketServerTest.testIdleConnection` which fails on trunk as well and I believe is unrelated).

> Mock consumer should behave consistent with actual consumer
> -----------------------------------------------------------
>
>                 Key: KAFKA-9679
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9679
>             Project: Kafka
>          Issue Type: Test
>          Components: consumer, streams
>            Reporter: Boyang Chen
>            Assignee: Sujay Hegde
>            Priority: Major
>              Labels: help-wanted, newbie, newbie++
>
> Right now in MockConsumer we shall return illegal state exception when the buffered records are not able to find corresponding assigned partitions. This is not the case for KafkaConsumer where we shall just not return those data during `poll()` call. This inconsistent behavior should be fixed.
> Note that if we are going to take this fix, the full unit tests need to be executed to make sure no regression is introduced, as some tests are potentially depending on the current MockConsumer behavior.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)