You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/11 08:16:17 UTC

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8074: sem: Remove PRIOINHERIT_FLAGS_ENABLE and use SEM_PRIO_INHERIT instead

pkarashchenko commented on code in PR #8074:
URL: https://github.com/apache/nuttx/pull/8074#discussion_r1066688914


##########
sched/semaphore/sem_setprotocol.c:
##########
@@ -103,10 +96,11 @@ int nxsem_set_protocol(FAR sem_t *sem, int protocol)
         return -ENOTSUP;
 
       default:
-        break;
+        return -EINVAL;
     }
 
-  return -EINVAL;
+  sem->flags = protocol;

Review Comment:
   Why not
   ```suggestion
     sem->flags &= ~SEM_PRIO_MASK;
     sem->flags = protocol & SEM_PRIO_MASK;
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org