[GitHub] [dubbo-spi-extensions] kentchenjh opened a new issue #81: sofa registry service name conflict

[GitBox <gi...@apache.org>]

kentchenjh opened a new issue #81:
URL: https://github.com/apache/dubbo-spi-extensions/issues/81


   have a look at 
   https://github.com/apache/dubbo/blob/56353aebc0c678582f7a2309dfd53d29b46deb3b/dubbo-registry/dubbo-registry-sofa/src/main/java/org/apache/dubbo/registry/sofa/SofaRegistry.java#L232-L246
   
   conflict happens in following situation.
   - first service: 
   version: v1, no group
   - second service: 
   group: v1, no version
   
   and both of them would have same service name like: com.dubbo.service:v1@dubbo. 
   it would be better if keep colon even version or group is empty. 
   e.g. 
   com.dubbo.service::v1
   com.dubbo.service:v1:
   
   @hengyunabc @ujjboy 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org