You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/06/08 03:46:47 UTC

[GitHub] [hadoop-ozone] GlenGeng commented on a change in pull request #1031: HDDS-3745. Improve OM and SCM performance with 64% by avoid call getServiceInfo in s3g

GlenGeng commented on a change in pull request #1031:
URL: https://github.com/apache/hadoop-ozone/pull/1031#discussion_r436443945



##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##########
@@ -170,10 +169,10 @@ public RpcClient(ConfigurationSource conf, String omServiceId)
         OzoneManagerProtocol.class, conf
     );
     dtService = omTransport.getDelegationTokenService();
-    ServiceInfoEx serviceInfoEx = ozoneManagerClient.getServiceInfo();
+    String certificate = ozoneManagerClient.getCaCertificate();
     String caCertPem = null;
     if (OzoneSecurityUtil.isSecurityEnabled(conf)) {
-      caCertPem = serviceInfoEx.getCaCertificate();
+      caCertPem = certificate;

Review comment:
       how about 
   ```
   caCertPem = ozoneManagerClient.getCaCertificate();
   ```
   
   only invoke when security is enabled.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org