You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/09/03 07:31:22 UTC
[GitHub] [hudi] xushiyan opened a new pull request #3593: [MINOR] Skip checkstyle and rat in Azure
xushiyan opened a new pull request #3593:
URL: https://github.com/apache/hudi/pull/3593
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #3593: [MINOR] Skip checkstyle and rat in Azure
Posted by GitBox <gi...@apache.org>.
xushiyan merged pull request #3593:
URL: https://github.com/apache/hudi/pull/3593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3593: [MINOR] Skip checkstyle and rat in Azure
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3593:
URL: https://github.com/apache/hudi/pull/3593#issuecomment-912325666
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfe80b8829184249f6807a5655d5d1e07cdb7bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9dfe80b8829184249f6807a5655d5d1e07cdb7bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dfe80b8829184249f6807a5655d5d1e07cdb7bd UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a change in pull request #3593: [MINOR] Skip checkstyle and rat in Azure
Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #3593:
URL: https://github.com/apache/hudi/pull/3593#discussion_r701664850
##########
File path: azure-pipelines.yml
##########
@@ -23,7 +23,7 @@ pool:
variables:
MAVEN_CACHE_FOLDER: $(Pipeline.Workspace)/.m2/repository
- MAVEN_OPTS: '-Dmaven.repo.local=$(MAVEN_CACHE_FOLDER)'
+ MAVEN_OPTS: '-Dmaven.repo.local=$(MAVEN_CACHE_FOLDER) -Dcheckstyle.skip=true -Drat.skip=true'
Review comment:
@yanghua Meant to let the GitHub Action CI jobs check this. Azure CI does the heavy lifting for actual tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3593: [MINOR] Skip checkstyle and rat in Azure
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3593:
URL: https://github.com/apache/hudi/pull/3593#issuecomment-912325666
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfe80b8829184249f6807a5655d5d1e07cdb7bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9dfe80b8829184249f6807a5655d5d1e07cdb7bd",
"triggerType" : "PUSH"
}, {
"hash" : "9c39bf791ed7d235bb114d9170ab99edbb8e8b0d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9c39bf791ed7d235bb114d9170ab99edbb8e8b0d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dfe80b8829184249f6807a5655d5d1e07cdb7bd UNKNOWN
* 9c39bf791ed7d235bb114d9170ab99edbb8e8b0d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on pull request #3593: [MINOR] Skip checkstyle and rat in Azure
Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3593:
URL: https://github.com/apache/hudi/pull/3593#issuecomment-912651576
> This makes sense to me. We can land once @yanghua also +1s
+1, just talked with @xushiyan after I know the reason behind the choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3593: [MINOR] Skip checkstyle and rat in Azure
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3593:
URL: https://github.com/apache/hudi/pull/3593#issuecomment-912325666
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfe80b8829184249f6807a5655d5d1e07cdb7bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9dfe80b8829184249f6807a5655d5d1e07cdb7bd",
"triggerType" : "PUSH"
}, {
"hash" : "9c39bf791ed7d235bb114d9170ab99edbb8e8b0d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1999",
"triggerID" : "9c39bf791ed7d235bb114d9170ab99edbb8e8b0d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dfe80b8829184249f6807a5655d5d1e07cdb7bd UNKNOWN
* 9c39bf791ed7d235bb114d9170ab99edbb8e8b0d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1999)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a change in pull request #3593: [MINOR] Skip checkstyle and rat in Azure
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3593:
URL: https://github.com/apache/hudi/pull/3593#discussion_r701662758
##########
File path: azure-pipelines.yml
##########
@@ -23,7 +23,7 @@ pool:
variables:
MAVEN_CACHE_FOLDER: $(Pipeline.Workspace)/.m2/repository
- MAVEN_OPTS: '-Dmaven.repo.local=$(MAVEN_CACHE_FOLDER)'
+ MAVEN_OPTS: '-Dmaven.repo.local=$(MAVEN_CACHE_FOLDER) -Dcheckstyle.skip=true -Drat.skip=true'
Review comment:
You mean we do not check the code style since now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3593: [MINOR] Skip checkstyle and rat in Azure
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3593:
URL: https://github.com/apache/hudi/pull/3593#issuecomment-912325666
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfe80b8829184249f6807a5655d5d1e07cdb7bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9dfe80b8829184249f6807a5655d5d1e07cdb7bd",
"triggerType" : "PUSH"
}, {
"hash" : "9c39bf791ed7d235bb114d9170ab99edbb8e8b0d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1999",
"triggerID" : "9c39bf791ed7d235bb114d9170ab99edbb8e8b0d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dfe80b8829184249f6807a5655d5d1e07cdb7bd UNKNOWN
* 9c39bf791ed7d235bb114d9170ab99edbb8e8b0d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1999)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3593: [MINOR] Skip checkstyle and rat in Azure
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3593:
URL: https://github.com/apache/hudi/pull/3593#issuecomment-912325666
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dfe80b8829184249f6807a5655d5d1e07cdb7bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9dfe80b8829184249f6807a5655d5d1e07cdb7bd",
"triggerType" : "PUSH"
}, {
"hash" : "9c39bf791ed7d235bb114d9170ab99edbb8e8b0d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1999",
"triggerID" : "9c39bf791ed7d235bb114d9170ab99edbb8e8b0d",
"triggerType" : "PUSH"
}, {
"hash" : "07bf83931b589adf0633205865ea6eba60f69286",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "07bf83931b589adf0633205865ea6eba60f69286",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dfe80b8829184249f6807a5655d5d1e07cdb7bd UNKNOWN
* 9c39bf791ed7d235bb114d9170ab99edbb8e8b0d Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1999)
* 07bf83931b589adf0633205865ea6eba60f69286 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org