[GitHub] [iceberg] rdblue commented on a diff in pull request #6837: Core, AWS: Allow disabling token refresh

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #6837:
URL: https://github.com/apache/iceberg/pull/6837#discussion_r1107638024


##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -105,6 +106,14 @@ public String token() {
     return properties().get(OAuth2Properties.TOKEN);
   }
 
+  @Value.Lazy
+  boolean refreshAuthByDefault() {
+    return PropertyUtil.propertyAsBoolean(
+        properties(),
+        CatalogProperties.AUTH_DEFAULT_REFRESH_ENABLED,
+        CatalogProperties.AUTH_DEFAULT_REFRESH_ENABLED_DEFAULT);

Review Comment:
   I don't think this is the right property to use. The intent of this property was to refresh a token provided as `token` in config if there was no other information about the token passed in. That's why it is "default refresh enabled" and not just "refresh enabled". When using this for signer, we probably also want to use a signer-specific config property.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org