You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 01:04:28 UTC
[GitHub] [spark] rednaxelafx opened a new pull request #28008:
[WIP][SPARK-XXXXX][SQL] Constant fold deterministic Scala UDFs with
foldable arguments
rednaxelafx opened a new pull request #28008: [WIP][SPARK-XXXXX][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008
### What changes were proposed in this pull request?
Constant fold deterministic Scala UDFs with foldable arguments, conservatively.
`ScalaUDF`s that meet all following criteria are subject to constant folding in this PR:
- deterministic
- all arguments are foldable
- does not throw an exception when evaluating the UDF for constant folding
### Why are the changes needed?
This is an optimization that enables more constant folding, improving the performance of a special case of Scala UDFs.
Catalyst already implements constant folding of expressions in a few places, through the pattern `if (e.foldable) e.eval(EmptyRow)`. One of the optimizer rules that specifically performs constant folding is `ConstantFolding`.
`ScalaUDF` does not override `foldable`, so it isn't subject to constant folding right now.
To enable constant folding of `ScalaUDF`s, it's tempting to make it override `foldable`:
```scala
override lazy val foldable: Boolean = deterministic && children.forall(_.foldable)
```
But `ScalaUDF`s are declared as deterministic by default, so it's possible for users to mis-declare a potentially exception-throwing UDF as deterministic, so for callers of the "constant folding" code pattern that do not expect an exception, overriding `ScalaUDF.foldable` in general may have a wide impact.
Instead, this PR tackles the problem in a conservative way, where the constant folding of `ScalaUDF`s is only implemented in the `ConstantFolding` rule, with special handling to catch non-fatal exceptions when evaluating a Scala UDF during constant folding and skip folding such UDFs.
### Does this PR introduce any user-facing change?
No.
Caveat: this PR assumes certain semantics of `Expression.deterministic`. Although it guards against potentially exception-throwing Scala UDFs being mis-declared as deterministic, it cannot guard against other kinds of mis-declarations, e.g.
- UDFs that are only expected to be invoked on executors;
- UDFs that return the same value but have other side-effects, such as modifying a static field.
Users should explicitly mark such UDFs as `asNondeterministic`.
### How was this patch tested?
Added a test case in `ConstantFoldingSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #28008: [SPARK-31240][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603592436
I looked over the two jira and I feel both are the same, so I will close the newer one as `duplicated` and update the PR title. If there is any problem, please re-update them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rednaxelafx commented on issue #28008: [SPARK-27692][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
rednaxelafx commented on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603599059
Thank you very much for linking this PR to the existing JIRA ticket and its PR!
I vaguely remember this had been implemented before but didn't find it in master and got curious... now I know >_<|||
It's highly likely that this PR won't be good enough to make the bar, but I'd like to hear other folks' opinions.
Thanks.
Basically this is a hurdle that we cannot get past until the APIs are clarified and the semantics of `ScalaUDF.deterministic` is strong enough for optimizations to depend on:
https://github.com/apache/spark/pull/24593#pullrequestreview-237361795
I had the same concerns when sending out this PR, and I'm more than okay to withdraw and close this PR given the current state of the API/semantics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28008: [SPARK-31240][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603587754
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120295/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28008:
[SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable
arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603675268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120297/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28008: [SPARK-27692][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603674381
**[Test build #120297 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120297/testReport)** for PR 28008 at commit [`ab15f5c`](https://github.com/apache/spark/commit/ab15f5cbd4befc78abb7e1cafdd9729ec29b7216).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28008:
[SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable
arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603587749
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28008:
[SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable
arguments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603598928
**[Test build #120297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120297/testReport)** for PR 28008 at commit [`ab15f5c`](https://github.com/apache/spark/commit/ab15f5cbd4befc78abb7e1cafdd9729ec29b7216).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28008:
[SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable
arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603597132
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28008: [SPARK-27692][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603598928
**[Test build #120297 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120297/testReport)** for PR 28008 at commit [`ab15f5c`](https://github.com/apache/spark/commit/ab15f5cbd4befc78abb7e1cafdd9729ec29b7216).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28008: [SPARK-31240][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603585076
**[Test build #120295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120295/testReport)** for PR 28008 at commit [`aed59d7`](https://github.com/apache/spark/commit/aed59d7c14557b2330fcbd95a1eb9bb451375c94).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28008:
[SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable
arguments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603585076
**[Test build #120295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120295/testReport)** for PR 28008 at commit [`aed59d7`](https://github.com/apache/spark/commit/aed59d7c14557b2330fcbd95a1eb9bb451375c94).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28008: [SPARK-31240][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603585496
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25005/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28008:
[SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable
arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603597137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25007/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28008: [SPARK-27692][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603597137
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25007/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28008: [SPARK-31240][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603588453
FYI, there was a similar try at https://github.com/apache/spark/pull/24593
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28008:
[SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable
arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603585492
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28008: [SPARK-27692][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603675268
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120297/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28008:
[SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable
arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603675265
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28008:
[SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable
arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603587754
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120295/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28008:
[SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable
arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603585496
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25005/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rednaxelafx commented on issue #28008: [SPARK-27692][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
rednaxelafx commented on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603609485
Closing this PR as I don't think it's going to work given the current API semantics.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28008: [SPARK-31240][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603587749
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28008: [SPARK-27692][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603675265
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28008: [SPARK-27692][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603597132
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28008: [SPARK-31240][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603587732
**[Test build #120295 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120295/testReport)** for PR 28008 at commit [`aed59d7`](https://github.com/apache/spark/commit/aed59d7c14557b2330fcbd95a1eb9bb451375c94).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28008: [SPARK-31240][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28008: [SPARK-31240][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008#issuecomment-603585492
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rednaxelafx closed pull request #28008: [SPARK-27692][SQL]
Constant fold deterministic Scala UDFs with foldable arguments
Posted by GitBox <gi...@apache.org>.
rednaxelafx closed pull request #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments
URL: https://github.com/apache/spark/pull/28008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org