You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "dreamtalen (via GitHub)" <gi...@apache.org> on 2025/09/22 21:11:26 UTC

[PR] Add Content_length header to S3 create_multipart [arrow-rs-object-store]

dreamtalen opened a new pull request, #496:
URL: https://github.com/apache/arrow-rs-object-store/pull/496

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #495 
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   Fixes error 411 when using S3 Client's multipart upload on GCS S3-compatible mode
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Adding the Content-Length header in the create_multipart() request as GCS requires.
   
   # Are there any user-facing changes?
   
   User won't see error 411 when using S3 Client's multipart upload on GCS S3-compatible mode
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please call them out.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Content_length header to S3 create_multipart [arrow-rs-object-store]

Posted by "dreamtalen (via GitHub)" <gi...@apache.org>.
dreamtalen commented on PR #496:
URL: https://github.com/apache/arrow-rs-object-store/pull/496#issuecomment-3335070622

   @tustvold  Could you help take a look please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Content_length header to S3 create_multipart [arrow-rs-object-store]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #496:
URL: https://github.com/apache/arrow-rs-object-store/pull/496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add Content_length header to S3 create_multipart [arrow-rs-object-store]

Posted by "dreamtalen (via GitHub)" <gi...@apache.org>.
dreamtalen commented on PR #496:
URL: https://github.com/apache/arrow-rs-object-store/pull/496#issuecomment-3354908773

   > Thanks for this contribution @dreamtalen -- this code looks good to me
   > 
   > Can you please add a test to this code? Maybe just a unit test that shows a `create_multipart` request has the expected content length? I am worried that we would lose this feature in some future refactor and not know about it
   > 
   > Also, have you tested this code in your own environment and verified it works?
   
   Thanks for the review. A unit test is added and I verified this change makes MPU work correctly for both GCS and AWS S3 with the S3Client.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org