[GitHub] [calcite] zinking commented on a diff in pull request #3136: [CALCITE-4771] add TRY_CAST function (enabled in MSSQL library)

["zinking (via GitHub)" <gi...@apache.org>]

zinking commented on code in PR #3136:
URL: https://github.com/apache/calcite/pull/3136#discussion_r1163542342


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -431,48 +431,59 @@ protected SqlOperatorFixture fixture() {
         true);
   }
 
-  /** Tests that CAST and SAFE_CAST are basically equivalent but SAFE_CAST is
-   * only available in BigQuery library. */
-  @Test void testCastVsSafeCast() {

Review Comment:
   adding a dialect udf shouldn't have touched so many existing tests, can you explain why?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org