You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/04/29 20:01:11 UTC

Review Request 20862: Usability: Check for JDK is installed on hosts as part of host checks

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20862/
-----------------------------------------------------------

Review request for Ambari, Sumit Mohanty and Sid Wagle.


Bugs: AMBARI-5624
    https://issues.apache.org/jira/browse/AMBARI-5624


Repository: ambari


Description
-------

PROBLEM:  Check for 1.7 when Install failing, can't find java 1.7

BUSINESS IMPACT:  Critical.

USE CASE:   When installing Ambari, if one of the machines has a bad or java 1.7 fails to be installed there isn't clear messaging or errors indicating this. Would like to request that when installing with 1.7 if a node fails to have 1.7 installed correctly there is clear error messaging indicating this.

h3. Scenarios to check on each host:

1) If using Custom JDK, confirm path is present, and is valid java home
2) Confirm java is the same version as on ambari server


Diffs
-----

  ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml db03a8b 
  ambari-server/src/main/resources/custom_actions/check_java_home.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20862/diff/


Testing
-------


Thanks,

Vitalyi Brodetskyi


Re: Review Request 20862: Usability: Check for JDK is installed on hosts as part of host checks

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20862/#review41739
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On April 29, 2014, 6:01 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20862/
> -----------------------------------------------------------
> 
> (Updated April 29, 2014, 6:01 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-5624
>     https://issues.apache.org/jira/browse/AMBARI-5624
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM:  Check for 1.7 when Install failing, can't find java 1.7
> 
> BUSINESS IMPACT:  Critical.
> 
> USE CASE:   When installing Ambari, if one of the machines has a bad or java 1.7 fails to be installed there isn't clear messaging or errors indicating this. Would like to request that when installing with 1.7 if a node fails to have 1.7 installed correctly there is clear error messaging indicating this.
> 
> h3. Scenarios to check on each host:
> 
> 1) If using Custom JDK, confirm path is present, and is valid java home
> 2) Confirm java is the same version as on ambari server
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml db03a8b 
>   ambari-server/src/main/resources/custom_actions/check_java_home.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20862/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 20862: Usability: Check for JDK is installed on hosts as part of host checks

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20862/#review41825
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On April 30, 2014, 10 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20862/
> -----------------------------------------------------------
> 
> (Updated April 30, 2014, 10 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty and Sid Wagle.
> 
> 
> Bugs: AMBARI-5624
>     https://issues.apache.org/jira/browse/AMBARI-5624
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PROBLEM:  Check for 1.7 when Install failing, can't find java 1.7
> 
> BUSINESS IMPACT:  Critical.
> 
> USE CASE:   When installing Ambari, if one of the machines has a bad or java 1.7 fails to be installed there isn't clear messaging or errors indicating this. Would like to request that when installing with 1.7 if a node fails to have 1.7 installed correctly there is clear error messaging indicating this.
> 
> h3. Scenarios to check on each host:
> 
> 1) If using Custom JDK, confirm path is present, and is valid java home
> 2) Confirm java is the same version as on ambari server
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69 
>   ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 7ac344a 
>   ambari-server/src/main/resources/custom_actions/check_host.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20862/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 20862: Usability: Check for JDK is installed on hosts as part of host checks

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20862/
-----------------------------------------------------------

(Updated April 30, 2014, 10 a.m.)


Review request for Ambari, Sumit Mohanty and Sid Wagle.


Changes
-------

New patch attached! Sumit please take a look at it.


Bugs: AMBARI-5624
    https://issues.apache.org/jira/browse/AMBARI-5624


Repository: ambari


Description
-------

PROBLEM:  Check for 1.7 when Install failing, can't find java 1.7

BUSINESS IMPACT:  Critical.

USE CASE:   When installing Ambari, if one of the machines has a bad or java 1.7 fails to be installed there isn't clear messaging or errors indicating this. Would like to request that when installing with 1.7 if a node fails to have 1.7 installed correctly there is clear error messaging indicating this.

h3. Scenarios to check on each host:

1) If using Custom JDK, confirm path is present, and is valid java home
2) Confirm java is the same version as on ambari server


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java de3db69 
  ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml 7ac344a 
  ambari-server/src/main/resources/custom_actions/check_host.py PRE-CREATION 

Diff: https://reviews.apache.org/r/20862/diff/


Testing
-------


Thanks,

Vitalyi Brodetskyi