You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/02 03:45:11 UTC
[GitHub] [spark] zhengruifeng commented on pull request #39339: [SPARK-41803][CONNECT][PYTHON] Add missing function `log(arg1, arg2)`
zhengruifeng commented on PR #39339:
URL: https://github.com/apache/spark/pull/39339#issuecomment-1368633966
@HyukjinKwon this PR just follows the existing design in PySpark, but I also feel it a bit problematic, the `log` function actually support only two cases:
1, `log(column)`;
2, `log(float_value, column)`
`log(column, column)` was actually not supported (both in PySpark and Scala)
```
py4j.Py4JException: Method log([class java.lang.String, class org.apache.spark.sql.Column]) does not exist
at py4j.reflection.ReflectionEngine.getMethod(ReflectionEngine.java:321)
at py4j.reflection.ReflectionEngine.getMethod(ReflectionEngine.java:342)
at py4j.Gateway.invoke(Gateway.java:276)
at py4j.commands.AbstractCommand.invokeMethod(AbstractCommand.java:132)
```
I will try to update the function signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org