You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by su...@apache.org on 2015/01/23 17:35:10 UTC
[1/3] trafficserver git commit: [TS-3294] Add null pointer check
Repository: trafficserver
Updated Branches:
refs/heads/master 4f043934c -> 1d19318b0
[TS-3294] Add null pointer check
Coverity CID:1021868
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/b62ea0c9
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/b62ea0c9
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/b62ea0c9
Branch: refs/heads/master
Commit: b62ea0c9c80f8dad41a62253bc1fd7b1d97b22e6
Parents: 4f04393
Author: Sudheer Vinukonda <su...@yahoo-inc.com>
Authored: Fri Jan 23 16:32:22 2015 +0000
Committer: Sudheer Vinukonda <su...@yahoo-inc.com>
Committed: Fri Jan 23 16:32:22 2015 +0000
----------------------------------------------------------------------
proxy/hdrs/HdrTest.cc | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/b62ea0c9/proxy/hdrs/HdrTest.cc
----------------------------------------------------------------------
diff --git a/proxy/hdrs/HdrTest.cc b/proxy/hdrs/HdrTest.cc
index 1ff196c..d7186fa 100644
--- a/proxy/hdrs/HdrTest.cc
+++ b/proxy/hdrs/HdrTest.cc
@@ -608,6 +608,12 @@ HdrTest::test_mime()
StrList slist;
cc_field = hdr.field_find("Cache-Control", 13);
+
+ if (cc_field == NULL) {
+ printf("FAILED: missing Cache-Control header\n\n");
+ return (failures_to_status("test_mime", 1));
+ }
+
// TODO: Do we need to check the "count" returned?
cc_field->value_get_comma_list(&slist); // FIX: correct usage?
[2/3] trafficserver git commit: [TS-3294] Add null pointer check
Posted by su...@apache.org.
[TS-3294] Add null pointer check
Coverity CID:1021867
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a2bc1245
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a2bc1245
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a2bc1245
Branch: refs/heads/master
Commit: a2bc1245859c2add6b0468586566c83f630889a5
Parents: b62ea0c
Author: Sudheer Vinukonda <su...@yahoo-inc.com>
Authored: Fri Jan 23 16:33:45 2015 +0000
Committer: Sudheer Vinukonda <su...@yahoo-inc.com>
Committed: Fri Jan 23 16:33:45 2015 +0000
----------------------------------------------------------------------
proxy/http/HttpTransact.cc | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a2bc1245/proxy/http/HttpTransact.cc
----------------------------------------------------------------------
diff --git a/proxy/http/HttpTransact.cc b/proxy/http/HttpTransact.cc
index e3f06f0..e9aa01b 100644
--- a/proxy/http/HttpTransact.cc
+++ b/proxy/http/HttpTransact.cc
@@ -7742,6 +7742,7 @@ HttpTransact::build_response(State* s, HTTPHdr* base_response, HTTPHdr* outgoing
for (size_t i = 0; i < sizeof(field_len) / sizeof(field_len[0]); i++) {
if (base_response->presence(field_presence[i])) {
field = base_response->field_find(field_name[i], field_len[i]);
+ ink_assert(field != NULL);
value = field->value_get(&len);
outgoing_response->value_append(field_name[i], field_len[i], value, len, 0);
}
[3/3] trafficserver git commit: [TS-3294] Add null pointer check
Posted by su...@apache.org.
[TS-3294] Add null pointer check
Coverity CID:1021866
Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/1d19318b
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/1d19318b
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/1d19318b
Branch: refs/heads/master
Commit: 1d19318b0d59436d007ccad85dfcbbfa1a722807
Parents: a2bc124
Author: Sudheer Vinukonda <su...@yahoo-inc.com>
Authored: Fri Jan 23 16:34:29 2015 +0000
Committer: Sudheer Vinukonda <su...@yahoo-inc.com>
Committed: Fri Jan 23 16:34:29 2015 +0000
----------------------------------------------------------------------
proxy/http/HttpTransact.cc | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/trafficserver/blob/1d19318b/proxy/http/HttpTransact.cc
----------------------------------------------------------------------
diff --git a/proxy/http/HttpTransact.cc b/proxy/http/HttpTransact.cc
index e9aa01b..39fe64a 100644
--- a/proxy/http/HttpTransact.cc
+++ b/proxy/http/HttpTransact.cc
@@ -5572,6 +5572,7 @@ HttpTransact::initialize_state_variables_from_response(State* s, HTTPHdr* incomi
if (incoming_response->presence(MIME_PRESENCE_TRANSFER_ENCODING)) {
MIMEField *field = incoming_response->field_find(MIME_FIELD_TRANSFER_ENCODING, MIME_LEN_TRANSFER_ENCODING);
+ ink_assert(field != NULL);
HdrCsvIter enc_val_iter;
int enc_val_len;