You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/26 19:36:09 UTC
[GitHub] [airflow] ipeluffo opened a new pull request #9540: Contrib cleanup
ipeluffo opened a new pull request #9540:
URL: https://github.com/apache/airflow/pull/9540
Close last files pending to be deprecated from contrib: https://github.com/apache/airflow/issues/9382
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9540: Contrib cleanup
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9540:
URL: https://github.com/apache/airflow/pull/9540#issuecomment-650558873
Can you un-draft it please :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9540: Contrib cleanup
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9540:
URL: https://github.com/apache/airflow/pull/9540#issuecomment-650709860
One more file has not been merged.
https://github.com/ipeluffo/airflow/blob/1aa053c8b6303d4fd7cd776a625e74e3e085ba86/airflow/contrib/utils/sendgrid.py
It is also worth adding tests to prevent regression. People can add files to this package by accident.
https://github.com/apache/airflow/blob/master/tests/test_project_structure.py#L56
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ipeluffo commented on pull request #9540: Contrib cleanup
Posted by GitBox <gi...@apache.org>.
ipeluffo commented on pull request #9540:
URL: https://github.com/apache/airflow/pull/9540#issuecomment-650561574
Ready for review. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #9540: Contrib cleanup
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #9540:
URL: https://github.com/apache/airflow/pull/9540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9540: Contrib cleanup
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9540:
URL: https://github.com/apache/airflow/pull/9540#issuecomment-650517082
Some wekday tests are failing :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ipeluffo edited a comment on pull request #9540: Contrib cleanup
Posted by GitBox <gi...@apache.org>.
ipeluffo edited a comment on pull request #9540:
URL: https://github.com/apache/airflow/pull/9540#issuecomment-650561574
@potiuk , it's ready for review. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9540: Contrib cleanup
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9540:
URL: https://github.com/apache/airflow/pull/9540#issuecomment-650558852
Looks good. I think it's ready to merge :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org