You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/21 07:26:51 UTC
[GitHub] [spark] eejbyfeldt opened a new pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
eejbyfeldt opened a new pull request #34351:
URL: https://github.com/apache/spark/pull/34351
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Change the anonymous functions in OpenHashMap to member methods. This avoid having a member which captures the OpenHashMap object in its closure. This fixes so that OpenHashMap instances can be serialized with Kryo with reference tracking turned off.
I am not sure why the original implementation had the anonymous function members in the first place. But if it was implemented that way for performance reason another possible fix is just to mark the `grow` and `move` members as transient.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
User might want to turn off referenceTracking in kryo since it has performance benefits, but currently this will unnecessary and unexpectedly prevent them from using some features of spark that uses OpenHashMap internally.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No.
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Existing tests and a new test in the `KryoSerializerSuite`.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-948345276
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952227934
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144625/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950342940
**[Test build #144567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144567/testReport)** for PR 34351 at commit [`c44ed49`](https://github.com/apache/spark/commit/c44ed49d061ce3496149fc52d0a536149060b684).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-948345276
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] eejbyfeldt commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
eejbyfeldt commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-951980736
> @eejbyfeldt can we apply this to the two other places that Josh mentions?
Yes, and done in https://github.com/apache/spark/pull/34351/commits/1e9edeae385fff3ecac30e8caee0564b1f8d3ef5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952959234
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950327690
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49036/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952091064
**[Test build #144625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144625/testReport)** for PR 34351 at commit [`1e9edea`](https://github.com/apache/spark/commit/1e9edeae385fff3ecac30e8caee0564b1f8d3ef5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952123980
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49095/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950339311
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49036/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950366648
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144567/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950366648
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144567/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950321288
**[Test build #144565 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144565/testReport)** for PR 34351 at commit [`c44ed49`](https://github.com/apache/spark/commit/c44ed49d061ce3496149fc52d0a536149060b684).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #34351:
URL: https://github.com/apache/spark/pull/34351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952227934
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144625/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952215005
**[Test build #144625 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144625/testReport)** for PR 34351 at commit [`1e9edea`](https://github.com/apache/spark/commit/1e9edeae385fff3ecac30e8caee0564b1f8d3ef5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950340049
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144565/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-951936968
@eejbyfeldt can we apply this to the two other places that Josh mentions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JoshRosen commented on a change in pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
JoshRosen commented on a change in pull request #34351:
URL: https://github.com/apache/spark/pull/34351#discussion_r733921709
##########
File path: core/src/main/scala/org/apache/spark/util/collection/OpenHashMap.scala
##########
@@ -149,17 +149,12 @@ class OpenHashMap[K : ClassTag, @specialized(Long, Int, Double) V: ClassTag](
}
}
- // The following member variables are declared as protected instead of private for the
- // specialization to work (specialized class extends the non-specialized one and needs access
- // to the "private" variables).
- // They also should have been val's. We use var's because there is a Scala compiler bug that
Review comment:
Spark was using Scala 2.9.3 at the time that this code was originally written, so it's quite likely that this has been fixed now that Spark uses Scala 2.12.
I searched the code and found that there's two places that duplicate this workaround:
- [PrimitiveKeyOpenHashMap](https://github.com/apache/spark/blob/0494dc90af48ce7da0625485a4dc6917a244d580/core/src/main/scala/org/apache/spark/util/collection/PrimitiveKeyOpenHashMap.scala#L120-L131)
- [GraphXPrimitiveKeyOpenHashMap](https://github.com/apache/spark/blob/0494dc90af48ce7da0625485a4dc6917a244d580/graphx/src/main/scala/org/apache/spark/graphx/util/collection/GraphXPrimitiveKeyOpenHashMap.scala#L140-L152)
Once we've decided on the best fix we should make sure to apply it there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950355747
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49038/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950318753
Jenkins test this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #34351:
URL: https://github.com/apache/spark/pull/34351#discussion_r734914728
##########
File path: core/src/main/scala/org/apache/spark/util/collection/OpenHashMap.scala
##########
@@ -149,17 +149,12 @@ class OpenHashMap[K : ClassTag, @specialized(Long, Int, Double) V: ClassTag](
}
}
- // The following member variables are declared as protected instead of private for the
- // specialization to work (specialized class extends the non-specialized one and needs access
- // to the "private" variables).
- // They also should have been val's. We use var's because there is a Scala compiler bug that
Review comment:
Oh n/m I read the comments out of order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #34351:
URL: https://github.com/apache/spark/pull/34351#discussion_r734914681
##########
File path: core/src/main/scala/org/apache/spark/util/collection/OpenHashMap.scala
##########
@@ -149,17 +149,12 @@ class OpenHashMap[K : ClassTag, @specialized(Long, Int, Double) V: ClassTag](
}
}
- // The following member variables are declared as protected instead of private for the
- // specialization to work (specialized class extends the non-specialized one and needs access
- // to the "private" variables).
- // They also should have been val's. We use var's because there is a Scala compiler bug that
Review comment:
Is there any way to check that the specialization still works - it would show up as a bunch of synthetic impl classes in the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952056326
Jenkins retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952156778
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49095/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950342306
Jenkins retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950339757
**[Test build #144565 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144565/testReport)** for PR 34351 at commit [`c44ed49`](https://github.com/apache/spark/commit/c44ed49d061ce3496149fc52d0a536149060b684).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950321288
**[Test build #144565 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144565/testReport)** for PR 34351 at commit [`c44ed49`](https://github.com/apache/spark/commit/c44ed49d061ce3496149fc52d0a536149060b684).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950342940
**[Test build #144567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144567/testReport)** for PR 34351 at commit [`c44ed49`](https://github.com/apache/spark/commit/c44ed49d061ce3496149fc52d0a536149060b684).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950365458
**[Test build #144567 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144567/testReport)** for PR 34351 at commit [`c44ed49`](https://github.com/apache/spark/commit/c44ed49d061ce3496149fc52d0a536149060b684).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952182864
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49095/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952091064
**[Test build #144625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144625/testReport)** for PR 34351 at commit [`1e9edea`](https://github.com/apache/spark/commit/1e9edeae385fff3ecac30e8caee0564b1f8d3ef5).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-952182864
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49095/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950339311
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49036/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950340049
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144565/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950334708
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49036/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #34351:
URL: https://github.com/apache/spark/pull/34351#discussion_r734914783
##########
File path: core/src/main/scala/org/apache/spark/util/collection/OpenHashMap.scala
##########
@@ -149,17 +149,12 @@ class OpenHashMap[K : ClassTag, @specialized(Long, Int, Double) V: ClassTag](
}
}
- // The following member variables are declared as protected instead of private for the
- // specialization to work (specialized class extends the non-specialized one and needs access
- // to the "private" variables).
- // They also should have been val's. We use var's because there is a Scala compiler bug that
Review comment:
Seems reasonable to me if it's no longer necessary to workaround in order to preserve specialization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950357926
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49038/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950357926
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/49038/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34351: [SPARK-37071][CORE] Make OpenHashMap serialize without reference tracking
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34351:
URL: https://github.com/apache/spark/pull/34351#issuecomment-950349176
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49038/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org