[GitHub] [echarts] plainheart commented on a change in pull request #14966: fix(option): check the missing component before merge theme

[GitBox <gi...@apache.org>]

plainheart commented on a change in pull request #14966:
URL: https://github.com/apache/echarts/pull/14966#discussion_r633375947



##########
File path: src/model/Global.ts
##########
@@ -238,6 +252,9 @@ class GlobalModel extends Model<ECUnitOption> {
 
         if (!type || type === 'recreate') {
             const baseOption = optionManager.mountOption(type === 'recreate');
+            if (__DEV__) {
+                checkMissingComponents(baseOption);

Review comment:
       Seems the code of `checkMissingComponents` will be bundled into dist files. I remember this is only used in development. Is that expected?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org