You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Viet Hung Nguyen (JIRA)" <ji...@apache.org> on 2008/01/08 21:54:34 UTC
[jira] Created: (GERONIMO-3739) SnapshotDBHelper in the monitoring
agent should not have static methods
SnapshotDBHelper in the monitoring agent should not have static methods
-----------------------------------------------------------------------
Key: GERONIMO-3739
URL: https://issues.apache.org/jira/browse/GERONIMO-3739
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Components: monitoring
Affects Versions: 2.1
Environment: windows
Reporter: Viet Hung Nguyen
Assignee: Viet Hung Nguyen
Attachments: geronimo.patch
The SnapshotDBHelper in the monitoring agent is a utility class right now. Other pieces of code can just use it by statically accessing its methods. However, this is a dangerous practice if the DataSources are not set properly before using it. So I suggest to force other pieces of code to instantiate the SnapshotDBHelper object first before using it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-3739) SnapshotDBHelper in the monitoring
agent should not have static methods
Posted by "Erik B. Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik B. Craig reassigned GERONIMO-3739:
---------------------------------------
Assignee: Viet Hung Nguyen (was: Erik B. Craig)
> SnapshotDBHelper in the monitoring agent should not have static methods
> -----------------------------------------------------------------------
>
> Key: GERONIMO-3739
> URL: https://issues.apache.org/jira/browse/GERONIMO-3739
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Assignee: Viet Hung Nguyen
> Attachments: geronimo.patch
>
>
> The SnapshotDBHelper in the monitoring agent is a utility class right now. Other pieces of code can just use it by statically accessing its methods. However, this is a dangerous practice if the DataSources are not set properly before using it. So I suggest to force other pieces of code to instantiate the SnapshotDBHelper object first before using it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-3739) SnapshotDBHelper in the monitoring
agent should not have static methods
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen resolved GERONIMO-3739.
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.1
> SnapshotDBHelper in the monitoring agent should not have static methods
> -----------------------------------------------------------------------
>
> Key: GERONIMO-3739
> URL: https://issues.apache.org/jira/browse/GERONIMO-3739
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Assignee: Viet Hung Nguyen
> Fix For: 2.1
>
> Attachments: geronimo.patch
>
>
> The SnapshotDBHelper in the monitoring agent is a utility class right now. Other pieces of code can just use it by statically accessing its methods. However, this is a dangerous practice if the DataSources are not set properly before using it. So I suggest to force other pieces of code to instantiate the SnapshotDBHelper object first before using it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-3739) SnapshotDBHelper in the monitoring
agent should not have static methods
Posted by "Erik B. Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik B. Craig reassigned GERONIMO-3739:
---------------------------------------
Assignee: Erik B. Craig (was: Viet Hung Nguyen)
> SnapshotDBHelper in the monitoring agent should not have static methods
> -----------------------------------------------------------------------
>
> Key: GERONIMO-3739
> URL: https://issues.apache.org/jira/browse/GERONIMO-3739
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Assignee: Erik B. Craig
> Attachments: geronimo.patch
>
>
> The SnapshotDBHelper in the monitoring agent is a utility class right now. Other pieces of code can just use it by statically accessing its methods. However, this is a dangerous practice if the DataSources are not set properly before using it. So I suggest to force other pieces of code to instantiate the SnapshotDBHelper object first before using it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3739) SnapshotDBHelper in the monitoring
agent should not have static methods
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3739:
---------------------------------------
Attachment: geronimo.patch
> SnapshotDBHelper in the monitoring agent should not have static methods
> -----------------------------------------------------------------------
>
> Key: GERONIMO-3739
> URL: https://issues.apache.org/jira/browse/GERONIMO-3739
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Assignee: Viet Hung Nguyen
> Attachments: geronimo.patch
>
>
> The SnapshotDBHelper in the monitoring agent is a utility class right now. Other pieces of code can just use it by statically accessing its methods. However, this is a dangerous practice if the DataSources are not set properly before using it. So I suggest to force other pieces of code to instantiate the SnapshotDBHelper object first before using it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3739) SnapshotDBHelper in the
monitoring agent should not have static methods
Posted by "Erik B. Craig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557054#action_12557054 ]
Erik B. Craig commented on GERONIMO-3739:
-----------------------------------------
Committed revision 610192.
> SnapshotDBHelper in the monitoring agent should not have static methods
> -----------------------------------------------------------------------
>
> Key: GERONIMO-3739
> URL: https://issues.apache.org/jira/browse/GERONIMO-3739
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: monitoring
> Affects Versions: 2.1
> Environment: windows
> Reporter: Viet Hung Nguyen
> Assignee: Erik B. Craig
> Attachments: geronimo.patch
>
>
> The SnapshotDBHelper in the monitoring agent is a utility class right now. Other pieces of code can just use it by statically accessing its methods. However, this is a dangerous practice if the DataSources are not set properly before using it. So I suggest to force other pieces of code to instantiate the SnapshotDBHelper object first before using it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.