You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Torsten Dettborn (JIRA)" <ji...@apache.org> on 2007/05/22 08:31:16 UTC
[jira] Created: (PLUTO-371) Portlet Filter
Portlet Filter
--------------
Key: PLUTO-371
URL: https://issues.apache.org/jira/browse/PLUTO-371
Project: Pluto
Issue Type: New Feature
Affects Versions: 1.1-286-COMPATIBILITY
Reporter: Torsten Dettborn
Fix For: 1.1-286-COMPATIBILITY
Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-371) Portlet Filter
Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12525906 ]
Torsten Dettborn commented on PLUTO-371:
----------------------------------------
Applied patch PortletFilter_090807.patch in 1.1-286-COMPABILITY version. The new revision number is 573811.
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip, PortletFilter_090807.patch
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PLUTO-371) Portlet Filter
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552555 ]
cdoremus edited comment on PLUTO-371 at 12/17/07 2:36 PM:
---------------------------------------------------------------
Thanks for the tip, Christian. I refactored SupportedModesServiceImpl in 1.1-286-trunk-merge branch to put back the loadPortletModes() method from the 1.1-286-COMPATBILITY branch in SVN rev 605023. I also got rid of a couple of unused methods.
Having FIlterManagerImpl initialization code in this class is poor encapsulation and should be refactored into another class that DriverConfiguration loads at startup.
was (Author: cdoremus):
Thanks for the tip, Christian. I refactored SupportedModesServiceImpl in 1.1-286-trunk-merge branch to put back the loadPortletModes() method from the 1.1-286-COMPATBILITY branch. I also got rid of a couple of unused methods.
Having FIlterManagerImpl initialization code in this class is poor encapsulation and should be refactored into another class that DriverConfiguration loads at startup.
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip, PortletFilter_090807.patch
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-371) Portlet Filter
Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Dettborn updated PLUTO-371:
-----------------------------------
Attachment: PortletFilter_090807.patch
fix bugs
add wildcards
add list for the filter lifecycle instead of singel element (see Spec)
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip, PortletFilter_090807.patch
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-371) Portlet Filter
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529062 ]
Craig Doremus commented on PLUTO-371:
-------------------------------------
Applied PortletFilter_090807.patch to 1.1-286-trunk-merge branch in SVN rev 577686. Thanks, Torsten!
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip, PortletFilter_090807.patch
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-371) Portlet Filter
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552555 ]
Craig Doremus commented on PLUTO-371:
-------------------------------------
Thanks for the tip, Christian. I refactored SupportedModesServiceImpl in 1.1-286-trunk-merge branch to put back the loadPortletModes() method from the 1.1-286-COMPATBILITY branch. I also got rid of a couple of unused methods.
Having FIlterManagerImpl initialization code in this class is poor encapsulation and should be refactored into another class that DriverConfiguration loads at startup.
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip, PortletFilter_090807.patch
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-371) Portlet Filter
Posted by "Christian Raschka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552504 ]
Christian Raschka commented on PLUTO-371:
-----------------------------------------
The SupportedModesServiceImpl is different (look for loadPortletmodes()). In the API patch there is (IMHO) only one line in SupportedModesServiceImpl which is important:
+ //init the portletapplication filter
+ FilterManagerImpl.addFilterApp(portletAppDD, app.getContextPath());
But i am not sure, if thats all.
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip, PortletFilter_090807.patch
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-371) Portlet Filter
Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Dettborn updated PLUTO-371:
-----------------------------------
Attachment: Filter_API_r15_050607.patch
For the filter part
The filter implementation starts with the FilterManagerImpl. There are all application stored. The initialization(addFilterApp) is called from the SupportedModesService. The position of the call have to be changed after merging the sources with the trunk. The method AddFilterApp themselves invokes addFilter from FilterChain. Inside FilterChain is a PortletFilter class where the class, filterConfig and some other parameter are stored, which you need for init and doFilter. To invoke processFilter in the PortletServlet:
request.setAttribute("filter-manager",
container.getRequiredContainerServices().
getPortalCallbackService().
getFilterManager());
add to the PortalDriverServlet in the doGet method. ProcessFilter(FilterManager) iterate over the applications and calls the doFilter method from the FilterChain. The doFilter method themselves iterate over all for the portlet registered filters.
classes been involved:
org.apache.pluto.driver.services.container.FilterChainImpl org.apache.pluto.driver.services.container.FilterConfigImpl org.apache.pluto.driver.services.container.FilterManagerImpl org.apache.pluto.driver.services.impl.resource.SupportedModesServiceImpl org.apache.pluto.driver.services.container.PortalCallbackServiceImpl org.apache.pluto.driver.services.container.SupportedModesServiceImpl
org.apache.pluto.driver.PortalDriverServlet
org.apache.pluto.spi.FilterManager
========================================================
For the API revision15 part
ActionRequest:
Add annotation
Generic Portlets:
Several changes for the annotation.
Event/EventImpl:
+QName getQNames
+String getName
-QName getName
PortletConfig:
+ public java.lang.String getDefaultEventNamespace();
PortletException:
+ private static final long serialVersionUID = 1L;
PortletModeException:
private static final long serialVersionUID = 1L;
- PortletModeResourceServing
PortletRequest:
-public static final String RESOURCE_SERVING_PHASE = "RESOURCE_SERVING_PHASE";
+ public static final String RESOURCE_PHASE = "RESOURCE_PHASE";
- public static final String FRAGMENT_SERVING_PHASE = "FRAGMENT_SERVING_PHASE";
PortletRequestDispatcher:
There is only one method for indlude/forwared(PortletRequest req, PortletResponse res)
PortletSecurityException:
+ private static final long serialVersionUID = 1L;
PortletSession:
+ getMap()
+ getMap(int i)
ProcessAction:
Complete new
ProcessEvent:
Show in Event, there are the same changes.(qname ->local name)
ReadOnlyException:
+ serialVersionUID
RenderMode:
Complete new.
StateAwareResponse:
public void setDefaultNamspacedEvents(Map<String, Object> events)
public void setEvent(String name, Object value)
UnavailableException:
+ private static final long serialVersionUID = 1L;
ValidatorException:
+ private static final long serialVersionUID = 1L;
WindowStateException:
+ private static final long serialVersionUID = 1L;
Missing in GenericPortlet
public String getDefaultEventNamespace() {
// TODO Auto-generated method stub
return null;
}
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-371) Portlet Filter
Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Dettborn updated PLUTO-371:
-----------------------------------
Attachment: mylar-context.zip
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-371) Portlet Filter
Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Torsten Dettborn updated PLUTO-371:
-----------------------------------
Fix Version/s: 1.1-286-trunk-merge
Affects Version/s: 1.1-286-trunk-merge
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (PLUTO-371) Portlet Filter
Posted by "Ate Douma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ate Douma closed PLUTO-371.
---------------------------
Resolution: Fixed
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY, 2.0.0
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY, 2.0.0
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip, PortletFilter_090807.patch
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-371) Portlet Filter
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552475 ]
Craig Doremus commented on PLUTO-371:
-------------------------------------
I'm not sure what part of PLUTO-233 that is missing in the trunk-merge branch? I checked out the TCKDriverServlet and it appears to be the same as the trunk (except lines 115-116 that were recently commented out by Torsten). Please advise?
I'm also unsure what patch in this issue that you want me to apply. I looked at the Filter_API_r15_050607.patch and saw that it was from rev 15 of the Portlet 2.0 API. I don't want to overwrite things that have changed sunsequently (since we are now at rev 30). Can you (or anyone else) point me to what's in the patch that's missing from the 1.1-286-trunk-merge branch?
Thank you.
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip, PortletFilter_090807.patch
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-371) Portlet Filter
Posted by "Christian Raschka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552462 ]
Christian Raschka commented on PLUTO-371:
-----------------------------------------
I have found the problem. In trunk-merge the patch from pluto-233 (https://issues.apache.org/jira/browse/PLUTO-233) from Elliot is missing. And then this api patch has to be committed. The 286-compat seems ok.
Craig is it possible for you to look at this?
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip, PortletFilter_090807.patch
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-371) Portlet Filter
Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505586 ]
Torsten Dettborn commented on PLUTO-371:
----------------------------------------
The patch "Filter_API_r15_050607.patch" has been committed. The new revision number is 545132.
> Portlet Filter
> --------------
>
> Key: PLUTO-371
> URL: https://issues.apache.org/jira/browse/PLUTO-371
> Project: Pluto
> Issue Type: New Feature
> Affects Versions: 1.1-286-COMPATIBILITY
> Reporter: Torsten Dettborn
> Fix For: 1.1-286-COMPATIBILITY
>
> Attachments: Filter_API_r15_050607.patch, mylar-context.zip
>
>
> Portlet filters are components to transform the request or response from a portlet. You have filter lifecycle for action-, event-,render- and resourceRequest/Response. The configurations is defined in the deployment descriptor. There is only one filter instance for each filter in the portlet application. For more details see the Portlet Specification Version 2.0 early draft 2 rev. 14.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.