You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/31 14:10:10 UTC
[GitHub] [rocketmq] mxsm opened a new pull request, #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
mxsm opened a new pull request, #4957:
URL: https://github.com/apache/rocketmq/pull/4957
**Make sure set the target branch to `develop`**
## What is the purpose of the change
close #4945
## Brief changelog
- Adjust the storedir format of test cases to the Windows platform
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mxsm commented on a diff in pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by GitBox <gi...@apache.org>.
mxsm commented on code in PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#discussion_r960138680
##########
store/src/test/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHATest.java:
##########
@@ -72,9 +73,9 @@ public class AutoSwitchHATest {
private String store2HaAddress;
private BrokerStatsManager brokerStatsManager = new BrokerStatsManager("simpleTest", true);
- private String tmpdir = System.getProperty("java.io.tmpdir");
- private String storePathRootParentDir = (StringUtils.endsWith(tmpdir, File.separator) ? tmpdir : tmpdir + File.separator) + UUID.randomUUID();
- private String storePathRootDir = storePathRootParentDir + File.separator + "store";
+
Review Comment:
I will be fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ltamber commented on pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by GitBox <gi...@apache.org>.
ltamber commented on PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#issuecomment-1234977128
why we don't use `import org.junit.rules.TemporaryFolder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Oliverwqcwrw commented on pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#issuecomment-1236811142
Hello @mxsm ,
There are some conflicts that need to be resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#issuecomment-1235072959
Hi @mxsm , As Itamber suggested, it will be better to use TemporaryFolder.
Also, this suggest is consistent with https://bazel.build/reference/test-encyclopedia#test-interaction-filesystem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] commented on pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#issuecomment-1709279334
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mxsm commented on pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by GitBox <gi...@apache.org>.
mxsm commented on PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#issuecomment-1235606367
> See [#4957 (comment)](https://github.com/apache/rocketmq/pull/4957#issuecomment-1235072959)
I will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mxsm commented on pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by GitBox <gi...@apache.org>.
mxsm commented on PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#issuecomment-1237165698
> Hello @mxsm , There are some conflicts that need to be resolved
I will do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on code in PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#discussion_r960132420
##########
store/src/test/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHATest.java:
##########
@@ -72,9 +73,9 @@ public class AutoSwitchHATest {
private String store2HaAddress;
private BrokerStatsManager brokerStatsManager = new BrokerStatsManager("simpleTest", true);
- private String tmpdir = System.getProperty("java.io.tmpdir");
- private String storePathRootParentDir = (StringUtils.endsWith(tmpdir, File.separator) ? tmpdir : tmpdir + File.separator) + UUID.randomUUID();
- private String storePathRootDir = storePathRootParentDir + File.separator + "store";
+
Review Comment:
CI is not passed
Tests in error:
AutoSwitchHATest.testTruncateEpochLogAndChangeMaster:380->checkMessage:193 » ConditionTimeout
Tests run: 148, Failures: 0, Errors: 1, Skipped: 9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mxsm commented on a diff in pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by GitBox <gi...@apache.org>.
mxsm commented on code in PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#discussion_r960138680
##########
store/src/test/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHATest.java:
##########
@@ -72,9 +73,9 @@ public class AutoSwitchHATest {
private String store2HaAddress;
private BrokerStatsManager brokerStatsManager = new BrokerStatsManager("simpleTest", true);
- private String tmpdir = System.getProperty("java.io.tmpdir");
- private String storePathRootParentDir = (StringUtils.endsWith(tmpdir, File.separator) ? tmpdir : tmpdir + File.separator) + UUID.randomUUID();
- private String storePathRootDir = storePathRootParentDir + File.separator + "store";
+
Review Comment:
I have will fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#issuecomment-1233660211
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4957?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4957](https://codecov.io/gh/apache/rocketmq/pull/4957?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (859b4bb) into [develop](https://codecov.io/gh/apache/rocketmq/commit/f043ca8c18ae7ce8ad27d09dda07abcc7d388596?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f043ca8) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## develop #4957 +/- ##
=============================================
+ Coverage 43.08% 43.13% +0.04%
- Complexity 7680 7694 +14
=============================================
Files 995 995
Lines 68966 68991 +25
Branches 9137 9142 +5
=============================================
+ Hits 29716 29761 +45
+ Misses 35513 35494 -19
+ Partials 3737 3736 -1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4957?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...controller/impl/DefaultBrokerHeartbeatManager.java](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL0RlZmF1bHRCcm9rZXJIZWFydGJlYXRNYW5hZ2VyLmphdmE=) | `77.38% <0.00%> (-3.58%)` | :arrow_down: |
| [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `60.43% <0.00%> (-2.20%)` | :arrow_down: |
| [.../apache/rocketmq/store/ha/DefaultHAConnection.java](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0RlZmF1bHRIQUNvbm5lY3Rpb24uamF2YQ==) | `65.86% <0.00%> (-1.21%)` | :arrow_down: |
| [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `39.22% <0.00%> (-0.56%)` | :arrow_down: |
| [...he/rocketmq/controller/impl/DLedgerController.java](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9pbXBsL0RMZWRnZXJDb250cm9sbGVyLmphdmE=) | `67.53% <0.00%> (-0.53%)` | :arrow_down: |
| [...cketmq/broker/processor/PopBufferMergeService.java](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcHJvY2Vzc29yL1BvcEJ1ZmZlck1lcmdlU2VydmljZS5qYXZh) | `37.44% <0.00%> (-0.24%)` | :arrow_down: |
| [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `69.21% <0.00%> (-0.16%)` | :arrow_down: |
| [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | `44.34% <0.00%> (-0.06%)` | :arrow_down: |
| [.../org/apache/rocketmq/proxy/config/ProxyConfig.java](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2NvbmZpZy9Qcm94eUNvbmZpZy5qYXZh) | `48.90% <0.00%> (ø)` | |
| [...apache/rocketmq/store/timer/TimerMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3RpbWVyL1RpbWVyTWVzc2FnZVN0b3JlLmphdmE=) | `54.28% <0.00%> (+0.09%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/rocketmq/pull/4957/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] closed pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
URL: https://github.com/apache/rocketmq/pull/4957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] commented on pull request #4957: [ISSUE #4945] Adjust the storedir format of test cases to the Windows platform
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4957:
URL: https://github.com/apache/rocketmq/pull/4957#issuecomment-1712666889
This PR was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org