Re: [PR] IGNITE-22214 Meta storage idempotent invokes: implement idempotent cache cleanup logic [ignite-3]

["denis-chudov (via GitHub)" <gi...@apache.org>]

denis-chudov commented on code in PR #3830:
URL: https://github.com/apache/ignite-3/pull/3830#discussion_r1628477266


##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/raft/MetaStorageWriteHandler.java:
##########
@@ -95,7 +112,14 @@ void handleWriteCommand(CommandClosure<WriteCommand> clo) {
         CommandClosure<WriteCommand> resultClosure;
 
         if (command instanceof IdempotentCommand) {
-            CommandId commandId = ((IdempotentCommand) command).id();
+            IdempotentCommand idempotentCommand = ((IdempotentCommand) command);
+            CommandId commandId = idempotentCommand.id();
+
+            // TODO: https://issues.apache.org/jira/browse/IGNITE-19417 Remove.
+            if (idempotentCommand.safeTime().getPhysical() % 100 == 0) {

Review Comment:
   Is it some kind of randomization for eviction? Maybe 100 is too big number and eviction will happen rarely? Or we will rework it to gc trigger soon and it doesnt matter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org