[GitHub] [cordova-browser] erisu edited a comment on issue #76: Add Node.js 12 to CI Services

[GitBox <gi...@apache.org>]

erisu edited a comment on issue #76: Add Node.js 12 to CI Services
URL: https://github.com/apache/cordova-browser/pull/76#issuecomment-490311145
 
 
   @timbru31 Without quotes doesn't cause any issues, but adding them back either way is not problem.
   
   YAML in general does not require quotation. There are exceptions for example the numbers wanted to be interpreted as string instead of a number, these should be explicitly wrapped.
   
   Since this value is piped into a terminal command (`NVM`) NVM will take the value as a string.
   
   ```
   nvm use 10.0.0
   ```
   
   Here is also an example of a string value for `node_js` that they forgot to wrap with quotes in the doc.
   https://docs.travis-ci.com/user/build-environment-updates/2015-02-03/#iojs-support
   
   For Elixir, they even talked about converting int/float values to strings only for consistency of the doc, not due to issues of the value not as a string. https://github.com/travis-ci/docs-travis-ci-com/pull/1490#issuecomment-335889711

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org