You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by bi...@apache.org on 2014/10/21 01:05:05 UTC
git commit: [flex-asjs] [refs/heads/develop] - FB caught these
compile errors
Repository: flex-asjs
Updated Branches:
refs/heads/develop 38f906b83 -> 4cf01424b
FB caught these compile errors
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/4cf01424
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/4cf01424
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/4cf01424
Branch: refs/heads/develop
Commit: 4cf01424b2f386b49e9f584cedb828a45e0db5b0
Parents: 38f906b
Author: OmPrakash Muppirala <bi...@gmail.com>
Authored: Mon Oct 20 15:58:13 2014 -0700
Committer: OmPrakash Muppirala <bi...@gmail.com>
Committed: Mon Oct 20 15:58:13 2014 -0700
----------------------------------------------------------------------
.../FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml | 2 +-
.../src/org/apache/flex/html/beads/PanelWithControlBarView.as | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4cf01424/frameworks/as/projects/FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml
----------------------------------------------------------------------
diff --git a/frameworks/as/projects/FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml b/frameworks/as/projects/FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml
index f887794..18eb9fb 100644
--- a/frameworks/as/projects/FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml
+++ b/frameworks/as/projects/FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml
@@ -46,6 +46,6 @@ limitations under the License.
</basic:style>
</basic:Label>
<basic:CloseButton id="closeButton" click="clickHandler()"
- visible="{ITitleBarModel(model).showCloseButton}";/>
+ visible="{ITitleBarModel(model).showCloseButton}"/>
</basic:MXMLBeadViewBase>
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4cf01424/frameworks/as/projects/FlexJSUI/src/org/apache/flex/html/beads/PanelWithControlBarView.as
----------------------------------------------------------------------
diff --git a/frameworks/as/projects/FlexJSUI/src/org/apache/flex/html/beads/PanelWithControlBarView.as b/frameworks/as/projects/FlexJSUI/src/org/apache/flex/html/beads/PanelWithControlBarView.as
index d53ad6d..338c616 100644
--- a/frameworks/as/projects/FlexJSUI/src/org/apache/flex/html/beads/PanelWithControlBarView.as
+++ b/frameworks/as/projects/FlexJSUI/src/org/apache/flex/html/beads/PanelWithControlBarView.as
@@ -176,7 +176,7 @@ package org.apache.flex.html.beads
/**
* @private
*/
- private function changeHandler(event:Event):void
+ override protected function changeHandler(event:Event):void
{
layoutChromeElements();
}
Re: git commit: [flex-asjs] [refs/heads/develop] - FB caught these
compile errors
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Mon, Oct 20, 2014 at 4:50 PM, Alex Harui <ah...@adobe.com> wrote:
>
>
> On 10/20/14, 4:22 PM, "OmPrakash Muppirala" <bi...@apache.org> wrote:
>
> >
> >How did these kind of errors pass through the daily builds?
> That’s a good question. What do you mean by “FB caught these compile
> errors”?
I don't see these errors caught when I compile the FlexJSUI swc using the
command line. But, when I open up the source code in an FB Flex Library
project, these errors are caught.
> How are you set up to compile?
I have two Flex Library projects, one for FlexJSUI and one for FlexJSJX.
The projects have their main source folders set to
git/flex-asjs/frameworks/as/projects/{ProjectName}/src. FlexJSJX has a
'project dependency' on FlexJSUI in the build path settings. Both of them
are compiled using the Flex SDK 4.13 compiler. I add the basic library
manifest namespace to both projects via 'Additional Compiler arguments'.
So, my changes to FlexJSUI and FlexJSJX are checked by FB as I type.
My FlexJS app project is a setup in FB to use the FlexJS SDK installed
using the Installer.
When I am ready to test the changes to FlexJSUI and FlexJSJX on my FlexJS
app project, I run ant in the flex-asjs\frameworks\as. Then I copy over
the swcs generated under flex-asjs\frameworks\as\libs into my
FlexJS_via_Installer\frameworks\as\libs folder.
Then I just do a clean, rebuild of my FlexJS app.
> In theory, FlexJS code is no
> longer compiled by MXMLC, but I’m guessing you are somehow set up to do
> so. Falcon still has bugs and isn’t catching these things (yet). It
> would be better to fix Falcon to report the error before fixing the AS
> code, but I’m sure I'll hit these patterns again later and fix it then.
>
>
Ah, so these are Falcon bugs which are getting caught by the older mxmlc.
I will do my best to create JIRA tickets for such issues I find in future.
Thanks,
Om
> -Alex
>
>
Re: git commit: [flex-asjs] [refs/heads/develop] - FB caught these
compile errors
Posted by Alex Harui <ah...@adobe.com>.
On 10/20/14, 4:22 PM, "OmPrakash Muppirala" <bi...@apache.org> wrote:
>
>How did these kind of errors pass through the daily builds?
That’s a good question. What do you mean by “FB caught these compile
errors”? How are you set up to compile? In theory, FlexJS code is no
longer compiled by MXMLC, but I’m guessing you are somehow set up to do
so. Falcon still has bugs and isn’t catching these things (yet). It
would be better to fix Falcon to report the error before fixing the AS
code, but I’m sure I'll hit these patterns again later and fix it then.
-Alex
Re: git commit: [flex-asjs] [refs/heads/develop] - FB caught these
compile errors
Posted by OmPrakash Muppirala <bi...@apache.org>.
On Mon, Oct 20, 2014 at 4:05 PM, <bi...@apache.org> wrote:
> Repository: flex-asjs
> Updated Branches:
> refs/heads/develop 38f906b83 -> 4cf01424b
>
>
> FB caught these compile errors
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/4cf01424
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/4cf01424
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/4cf01424
>
> Branch: refs/heads/develop
> Commit: 4cf01424b2f386b49e9f584cedb828a45e0db5b0
> Parents: 38f906b
> Author: OmPrakash Muppirala <bi...@gmail.com>
> Authored: Mon Oct 20 15:58:13 2014 -0700
> Committer: OmPrakash Muppirala <bi...@gmail.com>
> Committed: Mon Oct 20 15:58:13 2014 -0700
>
> ----------------------------------------------------------------------
> .../FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml | 2 +-
> .../src/org/apache/flex/html/beads/PanelWithControlBarView.as | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4cf01424/frameworks/as/projects/FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml
> ----------------------------------------------------------------------
> diff --git
> a/frameworks/as/projects/FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml
> b/frameworks/as/projects/FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml
> index f887794..18eb9fb 100644
> ---
> a/frameworks/as/projects/FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml
> +++
> b/frameworks/as/projects/FlexJSJX/src/org/apache/flex/html/beads/TitleBarView.mxml
> @@ -46,6 +46,6 @@ limitations under the License.
> </basic:style>
> </basic:Label>
> <basic:CloseButton id="closeButton" click="clickHandler()"
> -
> visible="{ITitleBarModel(model).showCloseButton}";/>
> + visible="{ITitleBarModel(model).showCloseButton}"/>
>
> </basic:MXMLBeadViewBase>
>
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4cf01424/frameworks/as/projects/FlexJSUI/src/org/apache/flex/html/beads/PanelWithControlBarView.as
> ----------------------------------------------------------------------
> diff --git
> a/frameworks/as/projects/FlexJSUI/src/org/apache/flex/html/beads/PanelWithControlBarView.as
> b/frameworks/as/projects/FlexJSUI/src/org/apache/flex/html/beads/PanelWithControlBarView.as
> index d53ad6d..338c616 100644
> ---
> a/frameworks/as/projects/FlexJSUI/src/org/apache/flex/html/beads/PanelWithControlBarView.as
> +++
> b/frameworks/as/projects/FlexJSUI/src/org/apache/flex/html/beads/PanelWithControlBarView.as
> @@ -176,7 +176,7 @@ package org.apache.flex.html.beads
> /**
> * @private
> */
> - private function changeHandler(event:Event):void
> + override protected function changeHandler(event:Event):void
> {
> layoutChromeElements();
> }
>
>
How did these kind of errors pass through the daily builds?
Thanks,
Om