You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by "oooforum (via GitHub)" <gi...@apache.org> on 2024/01/23 09:28:24 UTC
[PR] Fix for issue 60859 [openoffice]
oooforum opened a new pull request, #200:
URL: https://github.com/apache/openoffice/pull/200
If 1st slide is hidden and selected, show presentation does start after this.
Thanks to iammisc for this patch
https://bz.apache.org/ooo/show_bug.cgi?id=60859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Posted by "ardovm (via GitHub)" <gi...@apache.org>.
ardovm commented on PR #200:
URL: https://github.com/apache/openoffice/pull/200#issuecomment-1930585461
> After some testing I have found a problem: I get a crash when I hide the last slide, select it and start a presentation (by pressing F5). This does not happen when there is only one slide.
It may crash due to those `>`. @Pilot-Pirx if you can:
1. reproduce the problem on your build,
2. change `>` into `>=` and rebuild,
3. demonstrate on your own computer that it does not crash any more,
then you are good to merge with the above edit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Posted by "ardovm (via GitHub)" <gi...@apache.org>.
ardovm merged PR #200:
URL: https://github.com/apache/openoffice/pull/200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Fix for issue 60859 [openoffice]
Posted by "Pilot-Pirx (via GitHub)" <gi...@apache.org>.
Pilot-Pirx commented on code in PR #200:
URL: https://github.com/apache/openoffice/pull/200#discussion_r1468106347
##########
main/sd/source/ui/slideshow/slideshowimpl.cxx:
##########
@@ -236,6 +236,17 @@ AnimationSlideController::AnimationSlideController( Reference< XIndexAccess > xS
mnSlideCount = xSlides->getCount();
}
+void AnimationSlideController::setStartSlideNumber( sal_Int32 nSlideNumber )
+{
+ while( ( !maSlideVisible[nSlideNumber] )
+ || ( nSlideNumber > maSlideVisible.size() ) ) nSlideNumber++;
+
+ if(nSlideNumber > maSlideVisible.size())
+ mnStartSlideNumber = 0;
Review Comment:
This is a draft now until the code was successfully compiled by someone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Posted by "Pilot-Pirx (via GitHub)" <gi...@apache.org>.
Pilot-Pirx commented on PR #200:
URL: https://github.com/apache/openoffice/pull/200#issuecomment-2028644068
It did build fine and I have no crashes anymore.
The behavior now is logical for me.
Maybe this is something we would want to backport for AOO41X?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Posted by "Pilot-Pirx (via GitHub)" <gi...@apache.org>.
Pilot-Pirx commented on PR #200:
URL: https://github.com/apache/openoffice/pull/200#issuecomment-1932700934
I updated my build now with the above changes, but unfortunately it still crashes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Posted by "Pilot-Pirx (via GitHub)" <gi...@apache.org>.
Pilot-Pirx commented on PR #200:
URL: https://github.com/apache/openoffice/pull/200#issuecomment-1927852752
After some testing I have found a problem:
I get a crash when I hide the last slide, select it and start a presentation (by pressing F5).
This does not happen when there is only one slide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Fix for issue 60859 [openoffice]
Posted by "ardovm (via GitHub)" <gi...@apache.org>.
ardovm commented on code in PR #200:
URL: https://github.com/apache/openoffice/pull/200#discussion_r1463061431
##########
main/sd/source/ui/slideshow/slideshowimpl.cxx:
##########
@@ -236,6 +236,17 @@ AnimationSlideController::AnimationSlideController( Reference< XIndexAccess > xS
mnSlideCount = xSlides->getCount();
}
+void AnimationSlideController::setStartSlideNumber( sal_Int32 nSlideNumber )
+{
+ while( ( !maSlideVisible[nSlideNumber] )
+ || ( nSlideNumber > maSlideVisible.size() ) ) nSlideNumber++;
+
+ if(nSlideNumber > maSlideVisible.size())
+ mnStartSlideNumber = 0;
Review Comment:
Should all these checks: `(nSlideNumber > maSlideVisible.size())` be `>=` instead of `>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Fix for issue 60859 [openoffice]
Posted by "Pilot-Pirx (via GitHub)" <gi...@apache.org>.
Pilot-Pirx commented on code in PR #200:
URL: https://github.com/apache/openoffice/pull/200#discussion_r1466304570
##########
main/sd/source/ui/slideshow/slideshowimpl.cxx:
##########
@@ -236,6 +236,17 @@ AnimationSlideController::AnimationSlideController( Reference< XIndexAccess > xS
mnSlideCount = xSlides->getCount();
}
+void AnimationSlideController::setStartSlideNumber( sal_Int32 nSlideNumber )
+{
+ while( ( !maSlideVisible[nSlideNumber] )
+ || ( nSlideNumber > maSlideVisible.size() ) ) nSlideNumber++;
+
+ if(nSlideNumber > maSlideVisible.size())
+ mnStartSlideNumber = 0;
Review Comment:
If this PR was never tested, then you should convert it to a "draft".
This way it cannot be merged accidentally and we can continue to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Fix for issue 60859 [openoffice]
Posted by "oooforum (via GitHub)" <gi...@apache.org>.
oooforum commented on code in PR #200:
URL: https://github.com/apache/openoffice/pull/200#discussion_r1464537713
##########
main/sd/source/ui/slideshow/slideshowimpl.cxx:
##########
@@ -236,6 +236,17 @@ AnimationSlideController::AnimationSlideController( Reference< XIndexAccess > xS
mnSlideCount = xSlides->getCount();
}
+void AnimationSlideController::setStartSlideNumber( sal_Int32 nSlideNumber )
+{
+ while( ( !maSlideVisible[nSlideNumber] )
+ || ( nSlideNumber > maSlideVisible.size() ) ) nSlideNumber++;
+
+ if(nSlideNumber > maSlideVisible.size())
+ mnStartSlideNumber = 0;
Review Comment:
I don't know because I have no idea what maSlideVisible.size is supposed to return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Posted by "pedlino (via GitHub)" <gi...@apache.org>.
pedlino commented on PR #200:
URL: https://github.com/apache/openoffice/pull/200#issuecomment-2030108118
Windows build tested. Bug is fixed in trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Posted by "ardovm (via GitHub)" <gi...@apache.org>.
ardovm commented on PR #200:
URL: https://github.com/apache/openoffice/pull/200#issuecomment-2027708940
The logic had to be a little more complex than that.
If there is a visible slides after the selection, then it has to be selected.
Otherwise, we have to search for a visible slide backward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Posted by "Pilot-Pirx (via GitHub)" <gi...@apache.org>.
Pilot-Pirx commented on PR #200:
URL: https://github.com/apache/openoffice/pull/200#issuecomment-1925915743
Please find a Windows build here:
https://www.dropbox.com/scl/fi/ph0fogxba7wkbvxlfsr96/Apache_OpenOffice_4.5.0_Win_x86_install_en-US_Slide.exe?rlkey=vaxkxtaq9ix6vqms9q5d1uf15&dl=0
I cannot comment on the code itself but it does seem to fix the issue. If first slide is hidden, presentation now starts with the second slide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org