You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Marc DeXeT (JIRA)" <ji...@apache.org> on 2006/02/14 10:59:08 UTC
[jira] Created: (DIRSERVER-577) Loosen
LdapProtocolProvider-ServerLdapContext coupling.
Loosen LdapProtocolProvider-ServerLdapContext coupling.
-------------------------------------------------------
Key: DIRSERVER-577
URL: http://issues.apache.org/jira/browse/DIRSERVER-577
Project: Directory ApacheDS
Type: Improvement
Components: ldap
Versions: 1.0-RC1
Reporter: Marc DeXeT
Priority: Minor
LdapProtocoleProvider is heavely coupled to ServerLdapContext, even the package name has changed to 'server'.
To allow more custom override, I suggest to do 'instanceof' test at least on LdapContext.lookup("") result.
You can see such direct casting into SessionRegistry
/.../
else if ( ctx != null && allowAnonymous )
{
ServerLdapContext slc = null;
if ( ! ( ctx instanceof ServerLdapContext ) )
{
slc = ( ServerLdapContext ) ctx.lookup( "" );
}
else
{
slc = ( ServerLdapContext ) ctx;
}
/.../
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DIRSERVER-577) Loosen
LdapProtocolProvider-ServerLdapContext coupling.
Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu closed DIRSERVER-577.
-----------------------------------
Resolution: Fixed
The protocol provider no longer uses JNDI - we use the DirectoryService in core directly and the rewrite removes this problem.
> Loosen LdapProtocolProvider-ServerLdapContext coupling.
> -------------------------------------------------------
>
> Key: DIRSERVER-577
> URL: https://issues.apache.org/jira/browse/DIRSERVER-577
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: ldap
> Affects Versions: 1.0-RC1
> Reporter: Marc DeXeT
> Assignee: Alex Karasulu
> Priority: Minor
> Fix For: 1.5.4
>
>
> LdapProtocoleProvider is heavely coupled to ServerLdapContext, even the package name has changed to 'server'.
> To allow more custom override, I suggest to do 'instanceof' test at least on LdapContext.lookup("") result.
> You can see such direct casting into SessionRegistry
> /.../
> else if ( ctx != null && allowAnonymous )
> {
> ServerLdapContext slc = null;
> if ( ! ( ctx instanceof ServerLdapContext ) )
> {
> slc = ( ServerLdapContext ) ctx.lookup( "" );
> }
> else
> {
> slc = ( ServerLdapContext ) ctx;
> }
> /.../
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-577) Loosen
LdapProtocolProvider-ServerLdapContext coupling.
Posted by "Marc DeXeT (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612126#action_12612126 ]
Marc DeXeT commented on DIRSERVER-577:
--------------------------------------
It was a problem ! I have stop my LdapProtocoleProvider based proxy development because of this coupling !
> Loosen LdapProtocolProvider-ServerLdapContext coupling.
> -------------------------------------------------------
>
> Key: DIRSERVER-577
> URL: https://issues.apache.org/jira/browse/DIRSERVER-577
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: ldap
> Affects Versions: 1.0-RC1
> Reporter: Marc DeXeT
> Priority: Minor
> Fix For: 1.5.3
>
>
> LdapProtocoleProvider is heavely coupled to ServerLdapContext, even the package name has changed to 'server'.
> To allow more custom override, I suggest to do 'instanceof' test at least on LdapContext.lookup("") result.
> You can see such direct casting into SessionRegistry
> /.../
> else if ( ctx != null && allowAnonymous )
> {
> ServerLdapContext slc = null;
> if ( ! ( ctx instanceof ServerLdapContext ) )
> {
> slc = ( ServerLdapContext ) ctx.lookup( "" );
> }
> else
> {
> slc = ( ServerLdapContext ) ctx;
> }
> /.../
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-577) Loosen
LdapProtocolProvider-ServerLdapContext coupling.
Posted by "Alex Karasulu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Karasulu updated DIRSERVER-577:
------------------------------------
Fix Version/s: (was: 1.5.3)
1.5.4
Assignee: Alex Karasulu
We're revamping the protocol provider and codec in 1.5.4 so this may no longer be an issue for you. Please confirm this is still the case and we can look at it before releasing 1.5.4.
Thanks!
> Loosen LdapProtocolProvider-ServerLdapContext coupling.
> -------------------------------------------------------
>
> Key: DIRSERVER-577
> URL: https://issues.apache.org/jira/browse/DIRSERVER-577
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: ldap
> Affects Versions: 1.0-RC1
> Reporter: Marc DeXeT
> Assignee: Alex Karasulu
> Priority: Minor
> Fix For: 1.5.4
>
>
> LdapProtocoleProvider is heavely coupled to ServerLdapContext, even the package name has changed to 'server'.
> To allow more custom override, I suggest to do 'instanceof' test at least on LdapContext.lookup("") result.
> You can see such direct casting into SessionRegistry
> /.../
> else if ( ctx != null && allowAnonymous )
> {
> ServerLdapContext slc = null;
> if ( ! ( ctx instanceof ServerLdapContext ) )
> {
> slc = ( ServerLdapContext ) ctx.lookup( "" );
> }
> else
> {
> slc = ( ServerLdapContext ) ctx;
> }
> /.../
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DIRSERVER-577) Loosen
LdapProtocolProvider-ServerLdapContext coupling.
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612137#action_12612137 ]
Emmanuel Lecharny commented on DIRSERVER-577:
---------------------------------------------
I just meant that it _should_ not be a problem anymore, or if it is, we have to fix the issue.
> Loosen LdapProtocolProvider-ServerLdapContext coupling.
> -------------------------------------------------------
>
> Key: DIRSERVER-577
> URL: https://issues.apache.org/jira/browse/DIRSERVER-577
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: ldap
> Affects Versions: 1.0-RC1
> Reporter: Marc DeXeT
> Priority: Minor
> Fix For: 1.5.3
>
>
> LdapProtocoleProvider is heavely coupled to ServerLdapContext, even the package name has changed to 'server'.
> To allow more custom override, I suggest to do 'instanceof' test at least on LdapContext.lookup("") result.
> You can see such direct casting into SessionRegistry
> /.../
> else if ( ctx != null && allowAnonymous )
> {
> ServerLdapContext slc = null;
> if ( ! ( ctx instanceof ServerLdapContext ) )
> {
> slc = ( ServerLdapContext ) ctx.lookup( "" );
> }
> else
> {
> slc = ( ServerLdapContext ) ctx;
> }
> /.../
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DIRSERVER-577) Loosen
LdapProtocolProvider-ServerLdapContext coupling.
Posted by "Emmanuel Lecharny (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DIRSERVER-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny updated DIRSERVER-577:
----------------------------------------
Fix Version/s: 1.5.3
Let's kill this issue. I'm not sure it's even a problem right now.
> Loosen LdapProtocolProvider-ServerLdapContext coupling.
> -------------------------------------------------------
>
> Key: DIRSERVER-577
> URL: https://issues.apache.org/jira/browse/DIRSERVER-577
> Project: Directory ApacheDS
> Issue Type: Improvement
> Components: ldap
> Affects Versions: 1.0-RC1
> Reporter: Marc DeXeT
> Priority: Minor
> Fix For: 1.5.3
>
>
> LdapProtocoleProvider is heavely coupled to ServerLdapContext, even the package name has changed to 'server'.
> To allow more custom override, I suggest to do 'instanceof' test at least on LdapContext.lookup("") result.
> You can see such direct casting into SessionRegistry
> /.../
> else if ( ctx != null && allowAnonymous )
> {
> ServerLdapContext slc = null;
> if ( ! ( ctx instanceof ServerLdapContext ) )
> {
> slc = ( ServerLdapContext ) ctx.lookup( "" );
> }
> else
> {
> slc = ( ServerLdapContext ) ctx;
> }
> /.../
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.