You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/04/14 10:48:44 UTC
[GitHub] [systemds] Baunsgaard commented on a change in pull request #1218: [SYSTEMDS-2922] Federated Fused Codegen Operator - Rowwise
Baunsgaard commented on a change in pull request #1218:
URL: https://github.com/apache/systemds/pull/1218#discussion_r613140756
##########
File path: src/main/java/org/apache/sysds/runtime/instructions/fed/FEDInstructionUtils.java
##########
@@ -220,8 +221,11 @@ else if(inst instanceof QuaternaryCPInstruction) {
}
else if(inst instanceof SpoofCPInstruction) {
SpoofCPInstruction instruction = (SpoofCPInstruction) inst;
- if(instruction.getOperatorClass().getSuperclass() == SpoofCellwise.class && instruction.isFederated(ec))
+ if((instruction.getOperatorClass().getSuperclass() == SpoofCellwise.class
+ || instruction.getOperatorClass().getSuperclass() == SpoofRowwise.class)
+ && instruction.isFederated(ec)) {
Review comment:
Do you cover cases where the federated data is split on columns?
If not then this place would be ideal to ad another verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org