You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/03 01:46:30 UTC

[GitHub] [incubator-tvm] tqchen commented on pull request #5986: Fixes for GraphRuntime destruction

tqchen commented on pull request #5986:
URL: https://github.com/apache/incubator-tvm/pull/5986#issuecomment-653288776


   Thanks @samskalicky . 
   
   I agree that the destruction would be an issue here.  The fix however, is a bit adhoc. The root of problem is due to the fact of using a static GraphRuntime that get destructed.  
   
   The best approach might be just to ensure the destruction of the graph runtime at the time point, and not introducing graph runtime as a static object. 
   
   We could try to allocate raw pointer for the device API and never destory themselves(as the resource will de-allocate in unloading and no de-allocation is needed).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org