You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/16 01:50:34 UTC

[GitHub] [kafka] hachikuji commented on a change in pull request #9737: KAFKA-10828: Replacing endorsing with acknowledging for voters

hachikuji commented on a change in pull request #9737:
URL: https://github.com/apache/kafka/pull/9737#discussion_r543816185



##########
File path: raft/src/main/java/org/apache/kafka/raft/LeaderState.java
##########
@@ -50,8 +50,8 @@ protected LeaderState(
         this.highWatermark = Optional.empty();
 
         for (int voterId : voters) {
-            boolean hasEndorsedLeader = voterId == localId;
-            this.voterReplicaStates.put(voterId, new VoterState(voterId, hasEndorsedLeader));
+            boolean hasAcknowledgedLeader = voterId == localId;

Review comment:
       Could we add a brief comment in the class javadoc about what we mean by "acknowledged"? It would be helpful to mention specifically that the set of unacknowledged voters are targets for `BeginQuorumEpoch` requests from the leader.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org