[GitHub] jonathanli2 opened a new issue #339: Share code between ios CDVWKInAppBrowser and CDVUIInaAppBrowser

[GitBox <gi...@apache.org>]

jonathanli2 opened a new issue #339: Share code between ios CDVWKInAppBrowser and CDVUIInaAppBrowser
URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/339
 
 
   Hi,
   Currently both CDVWKInAppBrowser and CDVUIInAppBrowser are inherited from generic root interface of CDVPlugin. However, since CDVWKInAppBrowser and CDVUIInAppBrowser have the similar functions, they have many functions with the same implementation. 
   
   In order to avoid the duplicated code for easy maintenance, it is better to have a common base interface (like CDVInAppBrowserBase) containing the common code for both CDVUIInAppBrowser and CDVWKInAppBrowser interface. 
   
   Actually, it makes sense if the logic can be refactored to use CDVInAppBrowser as the base interface, and then derives CDVWKWebView and CDVUIWebView from it, instead of deriving all of them from CDVPlugin.
   
   Thanks
   Jonathan
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org