You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/10 13:44:22 UTC

[GitHub] [beam] kennknowles commented on pull request #12366: [BEAM-10572] Eliminate nullability errors from :sdks:java:extensions:sql:datacatalog

kennknowles commented on pull request #12366:
URL: https://github.com/apache/beam/pull/12366#issuecomment-671362622


   Here: https://github.com/apache/beam/blob/de8ff705145cbbc41bea7750a0a5d3553924ab3a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy#L763
   
   This block should be skipped if `compileAndRunTestsWithJava11` is set and Gradle's configuration phase runs using JDK8. I think it would be fine to just skip that block whenever `compileAndRunTestsWithJava11` is set.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org