[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #18865: [improve][broker] PIP-220 Added TransferShedder

[GitBox <gi...@apache.org>]

Demogorgon314 commented on code in PR #18865:
URL: https://github.com/apache/pulsar/pull/18865#discussion_r1046922944


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2431,6 +2431,53 @@ The delayed message index bucket time step(in seconds) in per bucket snapshot se
     )
     private long namespaceBundleUnloadingTimeoutMs = 60000;
 
+    @FieldContext(
+            category = CATEGORY_LOAD_BALANCER,
+            doc = "Option to enable the debug mode for TransferShedder. The debug mode prints more logs. "
+                    + "(only used by TransferSheddeer)"
+    )
+    private boolean loadBalancerExtentionsTransferShedderDebugModeEnabled = false;
+
+    @FieldContext(
+            category = CATEGORY_LOAD_BALANCER,
+            doc = "The target standard deviation of the resource usage across brokers "
+                    + "(100% resource usage is 1.0 load)."
+                    + "The shedder logic tries to distribute bundle load across brokers to meet this target std. "
+                    + "(only used by TransferSheddeer)"
+    )
+    private double loadBalancerExtentionsTransferShedderTargetLoadStd = 0.25;
+
+    @FieldContext(
+            category = CATEGORY_LOAD_BALANCER,
+            doc = "Option to enable the bundle transfer mode. "
+                    + "The transfer mode transfers bundles from source brokers to destination brokers. "
+                    + "(only used by TransferSheddeer)"
+    )
+    private boolean loadBalancerExtentionsTransferShedderTransferEnabled = true;
+
+    @FieldContext(
+            category = CATEGORY_LOAD_BALANCER,
+            doc = "maximum number of brokers to transfer bundle load for each unloading cycle."
+                    + " (only used by TransferSheddeer)"
+    )
+    private int loadBalancerExtentionsTransferShedderMaxNumberOfBrokerTransfersPerCycle = 3;
+
+    @FieldContext(
+            category = CATEGORY_LOAD_BALANCER,
+            doc = "minimum waiting time (in seconds) to update the next broker load data after transfers. "
+                    + "The logic tries to give enough time for each broker to recompute its load after unloading. "
+                    + "(only used by TransferSheddeer)"
+    )
+    private long loadBalancerExtentionsTransferShedderBrokerLoadDataUpdateMinWaitingTimeAfterUnloadingInSeconds = 180;

Review Comment:
   This configuration name is so long...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org