You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/10 01:54:39 UTC
[GitHub] [incubator-superset] betodealmeida opened a new pull request #11991: feat: update IDs when importing dashboards
betodealmeida opened a new pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Dashboards reference charts by their IDs in their JSON attributes (`position_json` and `json_metadata`). When importing a dashboard we need to update the IDs to the new ones, since imported charts will probably have different IDs.
In this PR we use the chart UUID to update references to charts inside the metadata of dashboards.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Updated unit test showing the chart ID is updated across all attributes.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **decrease** coverage by `3.62%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.62% 64.00% -3.63%
==========================================
Files 942 942
Lines 45805 46201 +396
Branches 4395 4399 +4
==========================================
- Hits 30975 29569 -1406
- Misses 14725 16456 +1731
- Partials 105 176 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.72% <ø> (+0.04%)` | :arrow_up: |
| python | `64.75% <96.00%> (+0.45%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **decrease** coverage by `3.61%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.62% 64.00% -3.62%
==========================================
Files 942 943 +1
Lines 45805 46334 +529
Branches 4395 4443 +48
==========================================
- Hits 30975 29658 -1317
- Misses 14725 16496 +1771
- Partials 105 180 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.75% <ø> (+0.07%)` | :arrow_up: |
| python | `64.75% <96.00%> (+0.45%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (9932132) into [master](https://codecov.io/gh/apache/incubator-superset/commit/696308715d285777952afe142fce877dc31ef188?el=desc) (6963087) will **decrease** coverage by `3.45%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.72% 64.27% -3.46%
==========================================
Files 951 471 -480
Lines 46603 29028 -17575
Branches 4558 0 -4558
==========================================
- Hits 31563 18657 -12906
+ Misses 14927 10371 -4556
+ Partials 113 0 -113
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.27% <96.00%> (-0.29%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.90% <0.00%> (-2.99%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `72.72% <0.00%> (-2.50%)` | :arrow_down: |
| ... and [489 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [6963087...9932132](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (59f5bc0) into [master](https://codecov.io/gh/apache/incubator-superset/commit/696308715d285777952afe142fce877dc31ef188?el=desc) (6963087) will **decrease** coverage by `3.84%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.72% 63.87% -3.85%
==========================================
Files 951 951
Lines 46603 46615 +12
Branches 4558 4558
==========================================
- Hits 31563 29777 -1786
- Misses 14927 16654 +1727
- Partials 113 184 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.69% <ø> (ø)` | |
| python | `64.59% <96.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [172 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [6963087...59f5bc0](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **decrease** coverage by `3.95%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.62% 63.66% -3.96%
==========================================
Files 942 942
Lines 45805 45842 +37
Branches 4395 4399 +4
==========================================
- Hits 30975 29185 -1790
- Misses 14725 16481 +1756
- Partials 105 176 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.72% <ø> (+0.04%)` | :arrow_up: |
| python | `64.22% <96.00%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [176 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (9932132) into [master](https://codecov.io/gh/apache/incubator-superset/commit/696308715d285777952afe142fce877dc31ef188?el=desc) (6963087) will **decrease** coverage by `7.33%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.72% 60.39% -7.34%
==========================================
Files 951 906 -45
Lines 46603 44699 -1904
Branches 4558 4051 -507
==========================================
- Hits 31563 26994 -4569
- Misses 14927 17705 +2778
+ Partials 113 0 -113
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.20% <ø> (-0.02%)` | :arrow_down: |
| javascript | `?` | |
| python | `64.27% <96.00%> (-0.29%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [348 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [6963087...9932132](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **decrease** coverage by `4.32%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.62% 63.29% -4.33%
==========================================
Files 942 942
Lines 45805 45842 +37
Branches 4395 4399 +4
==========================================
- Hits 30975 29017 -1958
- Misses 14725 16649 +1924
- Partials 105 176 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.72% <ø> (+0.04%)` | :arrow_up: |
| python | `63.63% <96.00%> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [184 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **decrease** coverage by `4.01%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.62% 63.61% -4.02%
==========================================
Files 942 466 -476
Lines 45805 28706 -17099
Branches 4395 0 -4395
==========================================
- Hits 30975 18260 -12715
+ Misses 14725 10446 -4279
+ Partials 105 0 -105
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.61% <96.00%> (-0.69%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/examples/energy.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `27.50% <0.00%> (-72.50%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.56% <0.00%> (-2.44%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| ... and [488 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (59f5bc0) into [master](https://codecov.io/gh/apache/incubator-superset/commit/696308715d285777952afe142fce877dc31ef188?el=desc) (6963087) will **decrease** coverage by `0.07%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.72% 67.65% -0.08%
==========================================
Files 951 951
Lines 46603 46627 +24
Branches 4558 4558
==========================================
- Hits 31563 31544 -19
- Misses 14927 14966 +39
- Partials 113 117 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.76% <ø> (-0.45%)` | :arrow_down: |
| javascript | `62.69% <ø> (ø)` | |
| python | `64.59% <96.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.11% <0.00%> (-3.85%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <0.00%> (-2.78%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `38.42% <0.00%> (-2.48%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `50.58% <0.00%> (-1.18%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.40% <0.00%> (+0.64%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [6963087...59f5bc0](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (9932132) into [master](https://codecov.io/gh/apache/incubator-superset/commit/696308715d285777952afe142fce877dc31ef188?el=desc) (6963087) will **decrease** coverage by `7.50%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.72% 60.22% -7.51%
==========================================
Files 951 906 -45
Lines 46603 44699 -1904
Branches 4558 4051 -507
==========================================
- Hits 31563 26919 -4644
- Misses 14927 17780 +2853
+ Partials 113 0 -113
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.72% <ø> (-0.50%)` | :arrow_down: |
| javascript | `?` | |
| python | `64.27% <96.00%> (-0.29%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [349 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [6963087...9932132](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **increase** coverage by `0.15%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
+ Coverage 67.62% 67.78% +0.15%
==========================================
Files 942 943 +1
Lines 45805 46344 +539
Branches 4395 4443 +48
==========================================
+ Hits 30975 31412 +437
- Misses 14725 14821 +96
- Partials 105 111 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.96% <ø> (-0.50%)` | :arrow_down: |
| javascript | `62.75% <ø> (+0.07%)` | :arrow_up: |
| python | `64.75% <96.00%> (+0.45%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `35.08% <0.00%> (-14.92%)` | :arrow_down: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `60.00% <0.00%> (-10.97%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
| [...frontend/src/components/ListView/Filters/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9pbmRleC50c3g=) | `82.35% <0.00%> (-4.61%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `58.11% <0.00%> (-3.85%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `86.11% <0.00%> (-2.78%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `38.42% <0.00%> (-2.48%)` | :arrow_down: |
| ... and [8 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (9932132) into [master](https://codecov.io/gh/apache/incubator-superset/commit/696308715d285777952afe142fce877dc31ef188?el=desc) (6963087) will **decrease** coverage by `3.91%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.72% 63.81% -3.92%
==========================================
Files 951 471 -480
Lines 46603 29028 -17575
Branches 4558 0 -4558
==========================================
- Hits 31563 18524 -13039
+ Misses 14927 10504 -4423
+ Partials 113 0 -113
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.81% <96.00%> (-0.75%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <0.00%> (-25.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-7.94%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.73% <0.00%> (-6.87%)` | :arrow_down: |
| ... and [494 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [6963087...9932132](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **decrease** coverage by `3.98%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.62% 63.63% -3.99%
==========================================
Files 942 466 -476
Lines 45805 28721 -17084
Branches 4395 0 -4395
==========================================
- Hits 30975 18278 -12697
+ Misses 14725 10443 -4282
+ Partials 105 0 -105
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.63% <96.00%> (-0.66%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/examples/energy.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `27.50% <0.00%> (-72.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| ... and [478 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **decrease** coverage by `4.06%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.62% 63.56% -4.07%
==========================================
Files 942 942
Lines 45805 45842 +37
Branches 4395 4399 +4
==========================================
- Hits 30975 29138 -1837
- Misses 14725 16528 +1803
- Partials 105 176 +71
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.72% <ø> (+0.04%)` | :arrow_up: |
| python | `64.06% <96.00%> (-0.24%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [182 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] eschutho commented on a change in pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
eschutho commented on a change in pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#discussion_r541470286
##########
File path: superset/dashboards/commands/importers/v1/utils.py
##########
@@ -29,6 +29,70 @@
JSON_KEYS = {"position": "position_json", "metadata": "json_metadata"}
+def build_uuid_to_id_map(position: Dict[str, Any]) -> Dict[str, int]:
+ return {
+ child["meta"]["uuid"]: child["meta"]["chartId"]
+ for child in position.values()
+ if (
+ isinstance(child, dict)
+ and child["type"] == "CHART"
+ and "uuid" in child["meta"]
+ )
+ }
+
+
+def update_id_refs(config: Dict[str, Any], chart_ids: Dict[str, int]) -> Dict[str, Any]:
+ """Update dashboard metadata to use new IDs"""
+ if not config.get("metadata"):
+ return config
+
+ fixed = config.copy()
+
+ # build map old_id => new_id
+ old_ids = build_uuid_to_id_map(fixed["position"])
+ id_map = {old_id: chart_ids[uuid] for uuid, old_id in old_ids.items()}
+
+ # fix metadata
+ metadata = fixed["metadata"]
+ if "timed_refresh_immune_slices" in metadata:
+ metadata["timed_refresh_immune_slices"] = [
+ id_map[old_id] for old_id in metadata["timed_refresh_immune_slices"]
+ ]
+
+ if "filter_scopes" in metadata:
+ # in filter_scopes the key is a chart ID as a string; we nede to udpate
Review comment:
nit typos
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **increase** coverage by `0.25%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
+ Coverage 67.62% 67.88% +0.25%
==========================================
Files 942 943 +1
Lines 45805 46344 +539
Branches 4395 4443 +48
==========================================
+ Hits 30975 31459 +484
- Misses 14725 14779 +54
- Partials 105 106 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.46% <ø> (ø)` | |
| javascript | `62.75% <ø> (+0.07%)` | :arrow_up: |
| python | `64.75% <96.00%> (+0.45%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [...nd/src/explore/components/controls/TextControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC50c3g=) | `60.00% <0.00%> (-10.97%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `43.85% <0.00%> (-6.15%)` | :arrow_down: |
| [...frontend/src/components/ListView/Filters/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy9pbmRleC50c3g=) | `82.35% <0.00%> (-4.61%)` | :arrow_down: |
| [...ntend/src/explore/components/AdhocFilterOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlck9wdGlvbi5qc3g=) | `73.33% <0.00%> (-1.67%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | `84.42% <0.00%> (-0.28%)` | :arrow_down: |
| [superset-frontend/src/components/DeleteModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVsZXRlTW9kYWwudHN4) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (9932132) into [master](https://codecov.io/gh/apache/incubator-superset/commit/696308715d285777952afe142fce877dc31ef188?el=desc) (6963087) will **decrease** coverage by `7.18%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.72% 60.54% -7.19%
==========================================
Files 951 906 -45
Lines 46603 44699 -1904
Branches 4558 4051 -507
==========================================
- Hits 31563 27064 -4499
- Misses 14927 17635 +2708
+ Partials 113 0 -113
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.20% <ø> (-0.02%)` | :arrow_down: |
| javascript | `?` | |
| python | `64.51% <96.00%> (-0.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [340 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [6963087...9932132](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **decrease** coverage by `3.61%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.62% 64.00% -3.62%
==========================================
Files 942 943 +1
Lines 45805 46334 +529
Branches 4395 4443 +48
==========================================
- Hits 30975 29658 -1317
- Misses 14725 16496 +1771
- Partials 105 180 +75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.75% <ø> (+0.07%)` | :arrow_up: |
| python | `64.75% <96.00%> (+0.45%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (59f5bc0) into [master](https://codecov.io/gh/apache/incubator-superset/commit/696308715d285777952afe142fce877dc31ef188?el=desc) (6963087) will **increase** coverage by `0.02%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
+ Coverage 67.72% 67.75% +0.02%
==========================================
Files 951 951
Lines 46603 46627 +24
Branches 4558 4558
==========================================
+ Hits 31563 31592 +29
+ Misses 14927 14922 -5
Partials 113 113
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.24% <ø> (+0.03%)` | :arrow_up: |
| javascript | `62.69% <ø> (ø)` | |
| python | `64.59% <96.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.40% <0.00%> (+0.64%)` | :arrow_up: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `93.65% <0.00%> (+1.58%)` | :arrow_up: |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `84.82% <0.00%> (+1.78%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [6963087...59f5bc0](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11991: feat: update IDs when importing dashboards
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11991:
URL: https://github.com/apache/incubator-superset/pull/11991#issuecomment-742184963
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=h1) Report
> Merging [#11991](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=desc) (df2c7c8) into [master](https://codecov.io/gh/apache/incubator-superset/commit/1e3aaab59075c5220e444759e07a26c080586fed?el=desc) (1e3aaab) will **decrease** coverage by `4.35%`.
> The diff coverage is `96.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11991 +/- ##
==========================================
- Coverage 67.62% 63.27% -4.36%
==========================================
Files 942 466 -476
Lines 45805 28706 -17099
Branches 4395 0 -4395
==========================================
- Hits 30975 18163 -12812
+ Misses 14725 10543 -4182
+ Partials 105 0 -105
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.27% <96.00%> (-1.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `91.66% <95.65%> (+3.66%)` | :arrow_up: |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `94.73% <100.00%> (+0.04%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/examples/energy.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `27.50% <0.00%> (-72.50%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| ... and [501 more](https://codecov.io/gh/apache/incubator-superset/pull/11991/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=footer). Last update [1e3aaab...df2c7c8](https://codecov.io/gh/apache/incubator-superset/pull/11991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org