You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2022/06/12 14:31:47 UTC

svn commit: r1901849 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java

Author: tilman
Date: Sun Jun 12 14:31:47 2022
New Revision: 1901849

URL: http://svn.apache.org/viewvc?rev=1901849&view=rev
Log:
PDFBOX-4892: optimize, as suggested by Valery Bokov

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java?rev=1901849&r1=1901848&r2=1901849&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/graphics/optionalcontent/PDOptionalContentMembershipDictionary.java Sun Jun 12 14:31:47 2022
@@ -17,6 +17,7 @@
 package org.apache.pdfbox.pdmodel.graphics.optionalcontent;
 
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import org.apache.pdfbox.cos.COSArray;
 import org.apache.pdfbox.cos.COSBase;
@@ -60,14 +61,15 @@ public class PDOptionalContentMembership
      */
     public List<PDPropertyList> getOCGs()
     {
-        List<PDPropertyList> list = new ArrayList<>();
         COSBase base = dict.getDictionaryObject(COSName.OCGS);
         if (base instanceof COSDictionary)
         {
-            list.add(PDPropertyList.create((COSDictionary) base));
+            return Collections.singletonList(PDPropertyList.create((COSDictionary) base));
         }
-        else if (base instanceof COSArray)
+
+        if (base instanceof COSArray)
         {
+            List<PDPropertyList> list = new ArrayList<>();
             COSArray ar = (COSArray) base;
             for (int i = 0; i < ar.size(); ++i)
             {
@@ -77,8 +79,10 @@ public class PDOptionalContentMembership
                     list.add(PDPropertyList.create((COSDictionary) elem));
                 }
             }
+            return list;
         }
-        return list;
+
+        return Collections.emptyList();
     }
 
     /**